Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2836183002: [DMC #6] Add TextMatchMarkerListImpl (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TextMatchMarkerListImpl This is the last of the MarkerType-specific marker list implementations for now. I'm also removing GenericDocumentMarkerListImpl in this CL since it's no longer needed. Right now this is very similar to CompositionMarkerList, but eventually this will be the only marker list impl that creates RenderedDocumentMarkers, and I will move the implementations of the text match marker-specific methods in DocumentMarkerController (e.g. everything that has anything to do with rendered rects) here. BUG=707867 Review-Url: https://codereview.chromium.org/2836183002 Cr-Commit-Position: refs/heads/master@{#472757} Committed: https://chromium.googlesource.com/chromium/src/+/2c8452ad5808e8466b92449340e199c334e3b991

Patch Set 1 #

Patch Set 2 : Add comments #

Patch Set 3 : Add NOTREACHED() to fix some builds #

Patch Set 4 : Use DocumentMarkerListEditor::AddMarkerWithoutMergingOverlapping() #

Patch Set 5 : Remove GenericDocumentMarkerListImpl #

Patch Set 6 : DECLARE_VIRTUAL_TRACE() #

Total comments: 1

Patch Set 7 : Create correct type of marker #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Patch Set 10 : Rebase #

Patch Set 11 : Rebase #

Total comments: 1

Patch Set 12 : final #

Messages

Total messages: 45 (38 generated)
rlanday
3 years, 7 months ago (2017-04-24 21:34:54 UTC) #2
Xiaocheng
https://codereview.chromium.org/2836183002/diff/100001/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp File third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp (right): https://codereview.chromium.org/2836183002/diff/100001/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp#newcode17 third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp:17: return new DocumentMarker(start_offset, end_offset, Color::kBlack, false, This creates a ...
3 years, 7 months ago (2017-04-28 18:24:11 UTC) #16
rlanday
On 2017/04/28 at 18:24:11, xiaochengh wrote: > https://codereview.chromium.org/2836183002/diff/100001/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp > File third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp (right): > > https://codereview.chromium.org/2836183002/diff/100001/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImplTest.cpp#newcode17 ...
3 years, 7 months ago (2017-04-28 18:37:09 UTC) #17
Xiaocheng
lgtm
3 years, 7 months ago (2017-04-28 18:43:26 UTC) #18
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2836183002/diff/200001/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h File third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h (right): https://codereview.chromium.org/2836183002/diff/200001/third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h#newcode15 third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h:15: class CORE_EXPORT TextMatchMarkerListImpl : public ...
3 years, 7 months ago (2017-05-18 01:21:34 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836183002/220001
3 years, 7 months ago (2017-05-18 06:49:09 UTC) #42
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 09:59:03 UTC) #45
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/2c8452ad5808e8466b92449340e1...

Powered by Google App Engine
This is Rietveld 408576698