[DMC #5.7] Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Currently this is a method on the general DocumentMarkerList interface. This CL
moves it to only be on SpellCheckMarkerListImpl and adds a typecast at the
callsite in DocumentMarkerController to enable this.

I am leaving the method implementation in DocumentMarkerListEditor.cpp in this CL
to make this CL smaller; I will move it to SpellCheckMarkerListImpl.cpp in a future
CL.

BUG=707867
Review-Url: https://codereview.chromium.org/2871823002
Cr-Commit-Position: refs/heads/master@{#472395}
Committed: https://chromium.googlesource.com/chromium/src/+/d38becdb2a4dda654d795cb841111778673c0b1d

[rlanday, 2017-05-09 01:13:24]

Description was changed from

==========
Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Currently this is a method on the general DocumentMarkerList interface. This CL
moves it to only be on SpellCheckMarkerListImpl and adds a typecast at the
callsite in DocumentMarkerController to enable this.

BUG=707867
==========

to

==========
Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Currently this is a method on the general DocumentMarkerList interface. This CL
moves it to only be on SpellCheckMarkerListImpl and adds a typecast at the
callsite in DocumentMarkerController to enable this.

I am leaving the method implementation in DocumentMarkerListEditor.cpp in this
CL
to make this CL smaller; I will move it to SpellCheckMarkerListImpl.cpp in a
future
CL.

BUG=707867
==========

[rlanday, 2017-05-09 01:13:25]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-05-09 01:22:07]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:23:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:31:08]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[rlanday, 2017-05-12 20:32:31]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 20:33:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:09:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Xiaocheng, 2017-05-16 20:54:29]

lgtm

[yosin_UTC9, 2017-05-17 03:30:47]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-17 03:30:47]

lgtm

[commit-bot: I haz the power, 2017-05-17 03:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:33:12]

This CL has an open dependency (Issue 2873483002 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[rlanday, 2017-05-17 07:38:43]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:39:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 09:25:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495006723140560,
"parent_rev": "f83ea6fa55b3a7d2c8ee80003ec1e1b2d9fcddfc", "commit_rev":
"d38becdb2a4dda654d795cb841111778673c0b1d"}

[commit-bot: I haz the power, 2017-05-17 09:26:07]

Description was changed from

==========
Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Currently this is a method on the general DocumentMarkerList interface. This CL
moves it to only be on SpellCheckMarkerListImpl and adds a typecast at the
callsite in DocumentMarkerController to enable this.

I am leaving the method implementation in DocumentMarkerListEditor.cpp in this
CL
to make this CL smaller; I will move it to SpellCheckMarkerListImpl.cpp in a
future
CL.

BUG=707867
==========

to

==========
Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Currently this is a method on the general DocumentMarkerList interface. This CL
moves it to only be on SpellCheckMarkerListImpl and adds a typecast at the
callsite in DocumentMarkerController to enable this.

I am leaving the method implementation in DocumentMarkerListEditor.cpp in this
CL
to make this CL smaller; I will move it to SpellCheckMarkerListImpl.cpp in a
future
CL.

BUG=707867

Review-Url: https://codereview.chromium.org/2871823002
Cr-Commit-Position: refs/heads/master@{#472395}
Committed:
https://chromium.googlesource.com/chromium/src/+/d38becdb2a4dda654d795cb84111...
==========

[commit-bot: I haz the power, 2017-05-17 09:26:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d38becdb2a4dda654d795cb84111...