Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp

Issue 2864243003: [DMC #5.8] Move SpellCheckMarkerListImpl::RemoveMarkersUnderWords() impl to correct place (Closed)
Patch Set: Remove blank line Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp
index 821a303acbeecba7d1f0de93142d809966ca23eb..d92853402b463a3638cd71f20b4da0276699e2c6 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.cpp
@@ -83,25 +83,6 @@ bool DocumentMarkerListEditor::RemoveMarkers(MarkerList* list,
return doc_dirty;
}
-// TODO(rlanday): move to SpellCheckMarkerListImpl.cpp
-bool SpellCheckMarkerListImpl::RemoveMarkersUnderWords(
- const String& node_text,
- const Vector<String>& words) {
- bool removed_markers = false;
- for (size_t j = markers_.size(); j > 0; --j) {
- const DocumentMarker& marker = *markers_[j - 1];
- const unsigned start = marker.StartOffset();
- const unsigned length = marker.EndOffset() - marker.StartOffset();
- const String& marker_text = node_text.Substring(start, length);
- if (words.Contains(marker_text)) {
- markers_.erase(j - 1);
- removed_markers = true;
- }
- }
-
- return removed_markers;
-}
-
bool DocumentMarkerListEditor::ShiftMarkers(MarkerList* list,
unsigned offset,
unsigned old_length,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698