Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2862813003: Enable header checking in WebKit/public/* (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable header checking in WebKit/public/* After the following CLs, third_party/WebKit/public/* is clean enough to turn on header checking in GN. - https://codereview.chromium.org/2849763002 - https://codereview.chromium.org/2853173002 - https://codereview.chromium.org/2858453002 - https://codereview.chromium.org/2851953002 BUG=716359 Review-Url: https://codereview.chromium.org/2862813003 Cr-Commit-Position: refs/heads/master@{#470213} Committed: https://chromium.googlesource.com/chromium/src/+/c50f8193152098b3d105545ffc78986e071a8623

Patch Set 1 #

Patch Set 2 : simplify rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-08 20:03:20 UTC) #4
brettw
lgtm
3 years, 7 months ago (2017-05-08 21:03:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862813003/20001
3 years, 7 months ago (2017-05-08 21:29:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/448103) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 01:26:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862813003/20001
3 years, 7 months ago (2017-05-09 01:33:43 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:37:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c50f8193152098b3d105545ffc78...

Powered by Google App Engine
This is Rietveld 408576698