Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2858453002: Fix missing headers in WebKit/public:mojo_bindings (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, abarth-chromium, Aaron Boodman, kinuko+serviceworker, yzshen+watch_chromium.org, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, darin (slow to review), blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing headers in WebKit/public:mojo_bindings This fixes disallowed inclusion of content/common/content_export.h in WebKit/public:mojo_bindings. Missing headers in some typemap files are amended. This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 Review-Url: https://codereview.chromium.org/2858453002 Cr-Commit-Position: refs/heads/master@{#468562} Committed: https://chromium.googlesource.com/chromium/src/+/56a5100afa68236b7c4e2c5e2cf6f92a79245792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/common/service_worker/service_worker_event_dispatcher.typemap View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_fetch_request.typemap View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.typemap View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
wychen
PTAL
3 years, 7 months ago (2017-05-02 02:23:39 UTC) #4
dcheng
lgtm
3 years, 7 months ago (2017-05-02 03:02:08 UTC) #7
jam
lgtm
3 years, 7 months ago (2017-05-02 04:58:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858453002/20001
3 years, 7 months ago (2017-05-02 04:59:49 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 05:05:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56a5100afa68236b7c4e2c5e2cf6...

Powered by Google App Engine
This is Rietveld 408576698