Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2853173002:
Fix header dependency in WebKit/public about testing (Closed)
DescriptionFix header dependency in WebKit/public about testing
This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h
in WebKit/public:blink_headers.
This is a prerequisite of whitelisting //third_party/WebKit/public
for header checking in GN.
BUG=716359
Review-Url: https://codereview.chromium.org/2853173002
Cr-Commit-Position: refs/heads/master@{#468560}
Committed: https://chromium.googlesource.com/chromium/src/+/1d2fd608a4f16afad4bfc2f1c856c520da1d2d79
Patch Set 1 #
Messages
Total messages: 16 (12 generated)
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update deps in WebKit/public to reflect actual usage (cont. 2) This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. There are still some unresolved issues: - testing/gmock/include/gmock/gmock.h BUG=716359 ========== to ========== Update deps in WebKit/public to reflect actual usage (cont. 2) This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. There is still unresolved issue: - content/common/content_export.h BUG=716359 ==========
Description was changed from ========== Update deps in WebKit/public to reflect actual usage (cont. 2) This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. There is still unresolved issue: - content/common/content_export.h BUG=716359 ========== to ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. There is still unresolved issue: - content/common/content_export.h BUG=716359 ==========
wychen@chromium.org changed reviewers: + haraken@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
Description was changed from ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. There is still unresolved issue: - content/common/content_export.h BUG=716359 ========== to ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 ==========
Description was changed from ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 ========== to ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 ==========
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493699999350610, "parent_rev":
"c8a96c63d6eb03dbc39afc03fd22e7f19f36569a", "commit_rev":
"1d2fd608a4f16afad4bfc2f1c856c520da1d2d79"}
Message was sent while issue was closed.
Description was changed from ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 ========== to ========== Fix header dependency in WebKit/public about testing This fixes disallowed inclusion of testing/gmock/include/gmock/gmock.h in WebKit/public:blink_headers. This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 Review-Url: https://codereview.chromium.org/2853173002 Cr-Commit-Position: refs/heads/master@{#468560} Committed: https://chromium.googlesource.com/chromium/src/+/1d2fd608a4f16afad4bfc2f1c856... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1d2fd608a4f16afad4bfc2f1c856... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
