|
|
DescriptionUpdate deps in WebKit/public to reflect actual usage
This is a prerequisite of whitelisting //third_party/WebKit/public
for header checking in GN.
BUG=716359
Review-Url: https://codereview.chromium.org/2851953002
Cr-Commit-Position: refs/heads/master@{#469522}
Committed: https://chromium.googlesource.com/chromium/src/+/06014b12cb233379169758b863703053d99cacc3
Patch Set 1 #Patch Set 2 : fix v8 headers (depends on v8 CL https://crrev.com/2853783002/) #Messages
Total messages: 21 (12 generated)
wychen@chromium.org changed reviewers: + haraken@chromium.org
PTAL. The size of the final binary slightly increased after this change. Is that expected?
On 2017/05/01 00:45:45, wychen wrote: > PTAL. The size of the final binary slightly increased after this change. Is that > expected? Why does this change increase the binary size? The added dependencies look good.
On 2017/05/01 00:49:52, haraken wrote: > On 2017/05/01 00:45:45, wychen wrote: > > PTAL. The size of the final binary slightly increased after this change. Is > that > > expected? > > Why does this change increase the binary size? That puzzled me. I even tried a symbol_level = 0 build, and the sizes were still different. My guess is the order of linking might be different, and some addresses are encoded in variable length coding. The difference is <100 bytes though. Shouldn't be a big deal.
On 2017/05/01 01:09:21, wychen wrote: > On 2017/05/01 00:49:52, haraken wrote: > > On 2017/05/01 00:45:45, wychen wrote: > > > PTAL. The size of the final binary slightly increased after this change. Is > > that > > > expected? > > > > Why does this change increase the binary size? > > That puzzled me. I even tried a symbol_level = 0 build, and the sizes were still > different. > My guess is the order of linking might be different, and some addresses are > encoded in variable length coding. > The difference is <100 bytes though. Shouldn't be a big deal. LGTM
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
According to https://codereview.chromium.org/2853783002/#msg18, I'll wait for 2 days before landing this.
Description was changed from ========== Update deps in WebKit/public to reflect actual usage This is the prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. There are still some unresolved issues: - content/common/content_export.h - testing/gmock/include/gmock/gmock.h BUG=716359 ========== to ========== Update deps in WebKit/public to reflect actual usage This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2851953002/#ps20001 (title: "fix v8 headers (depends on v8 CL https://crrev.com/2853783002/)")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493934374977260, "parent_rev": "d72c255b78bb35804ac82597879cc74a268ca3bf", "commit_rev": "06014b12cb233379169758b863703053d99cacc3"}
Message was sent while issue was closed.
Description was changed from ========== Update deps in WebKit/public to reflect actual usage This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 ========== to ========== Update deps in WebKit/public to reflect actual usage This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 Review-Url: https://codereview.chromium.org/2851953002 Cr-Commit-Position: refs/heads/master@{#469522} Committed: https://chromium.googlesource.com/chromium/src/+/06014b12cb233379169758b86370... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/06014b12cb233379169758b86370... |