Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2851953002: Update deps in WebKit/public to reflect actual usage (Closed)

Created:
3 years, 7 months ago by wychen
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update deps in WebKit/public to reflect actual usage This is a prerequisite of whitelisting //third_party/WebKit/public for header checking in GN. BUG=716359 Review-Url: https://codereview.chromium.org/2851953002 Cr-Commit-Position: refs/heads/master@{#469522} Committed: https://chromium.googlesource.com/chromium/src/+/06014b12cb233379169758b863703053d99cacc3

Patch Set 1 #

Patch Set 2 : fix v8 headers (depends on v8 CL https://crrev.com/2853783002/) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/public/BUILD.gn View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
wychen
PTAL. The size of the final binary slightly increased after this change. Is that expected?
3 years, 7 months ago (2017-05-01 00:45:45 UTC) #2
haraken
On 2017/05/01 00:45:45, wychen wrote: > PTAL. The size of the final binary slightly increased ...
3 years, 7 months ago (2017-05-01 00:49:52 UTC) #3
wychen
On 2017/05/01 00:49:52, haraken wrote: > On 2017/05/01 00:45:45, wychen wrote: > > PTAL. The ...
3 years, 7 months ago (2017-05-01 01:09:21 UTC) #4
haraken
On 2017/05/01 01:09:21, wychen wrote: > On 2017/05/01 00:49:52, haraken wrote: > > On 2017/05/01 ...
3 years, 7 months ago (2017-05-01 01:16:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851953002/1
3 years, 7 months ago (2017-05-01 05:12:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/415904)
3 years, 7 months ago (2017-05-01 05:23:57 UTC) #9
wychen
According to https://codereview.chromium.org/2853783002/#msg18, I'll wait for 2 days before landing this.
3 years, 7 months ago (2017-05-02 19:25:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851953002/20001
3 years, 7 months ago (2017-05-04 21:46:52 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:36:34 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/06014b12cb233379169758b86370...

Powered by Google App Engine
This is Rietveld 408576698