Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: ios/net/cookies/cookie_store_ios_test_util.mm

Issue 2861063003: Remove dangerous CanonicalCookie::Create method. (Closed)
Patch Set: Use creation_time for last_access_time as per Elly's suggestion. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/net/cookies/cookie_store_ios.mm ('k') | net/cookies/canonical_cookie.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios_test_util.mm
diff --git a/ios/net/cookies/cookie_store_ios_test_util.mm b/ios/net/cookies/cookie_store_ios_test_util.mm
index f3771b6be6078d28490b1d0e8ee4dab7ea08a1e6..a660968f89563948a3ba282fff8ea9cdd4ecd169 100644
--- a/ios/net/cookies/cookie_store_ios_test_util.mm
+++ b/ios/net/cookies/cookie_store_ios_test_util.mm
@@ -42,10 +42,10 @@ void TestPersistentCookieStore::RunLoadedCallback() {
std::unique_ptr<net::CanonicalCookie> bad_canonical_cookie(
net::CanonicalCookie::Create(
- GURL("http://domain/"), "name", "\x81r\xe4\xbd\xa0\xe5\xa5\xbd",
- std::string(), "/path/",
+ "name", "\x81r\xe4\xbd\xa0\xe5\xa5\xbd", "domain", "/path/",
base::Time(), // creation
base::Time(), // expires
+ base::Time(), // last accessed
false, // secure
false, // httponly
net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
@@ -138,4 +138,4 @@ void ClearCookies() {
EXPECT_EQ(0u, [[store cookies] count]);
}
-} // namespace net
+} // namespace net
« no previous file with comments | « ios/net/cookies/cookie_store_ios.mm ('k') | net/cookies/canonical_cookie.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698