Remove dangerous CanonicalCookie::Create method.

content/browser/browsing_data/browsing_data_remover_impl_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <list>
 #include <memory>
 #include <set>
@@ skipping 100 matching lines @@
   base::Time remove_begin;
   base::Time remove_end;
   StoragePartition::OriginMatcherFunction origin_matcher;
   StoragePartition::CookieMatcherFunction cookie_matcher;
 
   StoragePartitionRemovalData() {}
 };
 
 net::CanonicalCookie CreateCookieWithHost(const GURL& source) {
   std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
-      source, "A", "1", std::string(), "/", base::Time::Now(),
-      base::Time::Now(), false, false, net::CookieSameSite::DEFAULT_MODE,
+      "A", "1", "." + source.host(), "/", base::Time::Now(), base::Time::Now(),

[mmenke, 2017/05/05 17:51:56]

I think this used to be exact matches?  (i.e., no dot)

[Randy Smith (Not in Mondays), 2017/05/05 21:12:58]

Yep, oops.  Doesn't change the test outcome to fix it, though :-}.

+      base::Time(), false, false, net::CookieSameSite::DEFAULT_MODE,
       net::COOKIE_PRIORITY_MEDIUM));
   EXPECT_TRUE(cookie);
   return *cookie;
 }
 
 class TestStoragePartition : public StoragePartition {
  public:
   TestStoragePartition() {}
   ~TestStoragePartition() override {}
 
@@ skipping 1515 matching lines @@
 
   // Add one more deletion and wait for it.
   BlockUntilBrowsingDataRemoved(
       base::Time(), base::Time::Max(), BrowsingDataRemover::DATA_TYPE_COOKIES,
       BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB);
 
   EXPECT_FALSE(remover->is_removing());
 }
 
 }  // namespace content