Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2859073002: Revert of DevTools: support resolving a UILocation to multiple raw script locations (Closed)

Created:
3 years, 7 months ago by caseq
Modified:
3 years, 7 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: support resolving a UILocation to multiple raw script locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ ) Reason for revert: We decided that we don't need that. Original issue's description: > DevTools: support resolving a UILocation to multiple raw script locations > > This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array > > BUG=717694 > > Review-Url: https://codereview.chromium.org/2857453002 > Cr-Commit-Position: refs/heads/master@{#468825} > Committed: https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d977b4ed406cf72 TBR=dgozman@chromium.org,lushnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717694 Review-Url: https://codereview.chromium.org/2859073002 Cr-Commit-Position: refs/heads/master@{#469206} Committed: https://chromium.googlesource.com/chromium/src/+/9c9853ec9c2a166dc204e64595708202c48dcf26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -96 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-formatter-breakpoints-3.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 2 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 1 chunk +16 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
caseq
Created Revert of DevTools: support resolving a UILocation to multiple raw script locations
3 years, 7 months ago (2017-05-03 23:56:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859073002/1
3 years, 7 months ago (2017-05-03 23:56:25 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:57:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c9853ec9c2a166dc204e6459570...

Powered by Google App Engine
This is Rietveld 408576698