Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2859073002: Revert of DevTools: support resolving a UILocation to multiple raw script locations (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
index f1f6b7c278c0d9dfb038ec68674706bed504635f..469d9b7a9d5343069718cf4f4a3e13df0876d85d 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
@@ -170,11 +170,11 @@
* @param {!Workspace.UISourceCode} uiSourceCode
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {!Array<!SDK.DebuggerModel.Location>}
- */
- uiLocationToRawLocations(uiSourceCode, lineNumber, columnNumber) {
+ * @return {?SDK.DebuggerModel.Location}
+ */
+ uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber) {
var sourceMapping = uiSourceCode[Bindings.DebuggerWorkspaceBinding._sourceMappingSymbol];
- return sourceMapping ? sourceMapping.uiLocationToRawLocations(uiSourceCode, lineNumber, columnNumber) : [];
+ return sourceMapping && sourceMapping.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);
}
/**
@@ -182,10 +182,10 @@
* @return {!Workspace.UILocation}
*/
normalizeUILocation(uiLocation) {
- var rawLocations =
- this.uiLocationToRawLocations(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber);
- if (rawLocations.length)
- return this.rawLocationToUILocation(rawLocations[0]);
+ var rawLocation =
+ this.uiLocationToRawLocation(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber);
+ if (rawLocation)
+ return this.rawLocationToUILocation(rawLocation);
return uiLocation;
}
@@ -586,9 +586,9 @@
* @param {!Workspace.UISourceCode} uiSourceCode
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {!Array<!SDK.DebuggerModel.Location>}
- */
- uiLocationToRawLocations(uiSourceCode, lineNumber, columnNumber) {},
+ * @return {?SDK.DebuggerModel.Location}
+ */
+ uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber) {},
/**
* @return {boolean}

Powered by Google App Engine
This is Rietveld 408576698