Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2859073002: Revert of DevTools: support resolving a UILocation to multiple raw script locations (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index a81fa0c4773f009fa4b7872fa751ac3e4cd83d8b..09cf0a8058b8f3b613ca0164b9fb8b043216be28 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -645,16 +645,14 @@
if (!executionContext)
return;
// Always use 0 column.
- var rawLocations =
- Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations(uiLocation.uiSourceCode, uiLocation.lineNumber, 0);
- // TODO(kozyatinskiy): make it possible to continue to multiple locations (whichever is hit first).
- var location = rawLocations.find(location => location.debuggerModel === executionContext.debuggerModel);
- if (!location)
+ var rawLocation =
+ Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiLocation.uiSourceCode, uiLocation.lineNumber, 0);
+ if (!rawLocation || rawLocation.debuggerModel !== executionContext.debuggerModel)
return;
if (!this._prepareToResume())
return;
- location.continueToLocation();
+ rawLocation.continueToLocation();
}
_toggleBreakpointsActive() {
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698