DevTools: support resolving a UILocation to multiple raw script locations

DevTools: support resolving a UILocation to multiple raw script locations

This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array

BUG=717694
Review-Url: https://codereview.chromium.org/2857453002
Cr-Commit-Position: refs/heads/master@{#468825}
Committed: https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d977b4ed406cf72

[caseq, 2017-05-02 01:27:52]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[dgozman, 2017-05-02 19:47:41]

Let's have a description and a bug.

https://codereview.chromium.org/2857453002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
(right):

https://codereview.chromium.org/2857453002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js:270:
uiSourceCode, textRange.startLine, textRange.startColumn)[0];
This is suspicious. What if there are multiple and the order is different? We
will fail check in line 273.

https://codereview.chromium.org/2857453002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2857453002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:162:
var entry = sourceMap.firstSourceLineMapping(uiSourceCode.url(), lineNumber);
We can actually return multiple here. Are you going to follow up?

https://codereview.chromium.org/2857453002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2857453002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:650: if
(!rawLocations.length || rawLocations[0].debuggerModel !==
executionContext.debuggerModel)
TODO(kozyatinskiy): make it possible to continue to multiple locations
(whichever is hit first).

[caseq, 2017-05-02 21:28:56]

Description was changed from

==========
DevTools: turn uiLocationToRawLocation into uiLocationToRawLocations, make it
return an array
==========

to

==========
DevTools: support resolving a UILocation to multiple raw script locations

This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it
return an array

BUG=717694
==========

[caseq, 2017-05-02 21:29:05]

All done, ptal!

[dgozman, 2017-05-02 21:36:45]

lgtm, but let's not introduce uniqueScriptId()

https://codereview.chromium.org/2857453002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
(right):

https://codereview.chromium.org/2857453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js:273:
var startLocationsByScript = new Map(startLocations.map(location =>
[location.uniqueScriptId(), location]));
Why not just compare them all?

for (var startLocation of startLocations)
  for (var endLocation of endLocations)
    if (startLocation.script() === endLocation.script())
      ...

https://codereview.chromium.org/2857453002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
(right):

https://codereview.chromium.org/2857453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:162:
.filter(location => location);
nit: location => !!location

[caseq, 2017-05-02 22:05:48]

Patchset #3 (id:40001) has been deleted

[caseq, 2017-05-02 22:06:39]

The CQ bit was checked by caseq@chromium.org

[caseq, 2017-05-02 22:06:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2857453002/#ps60001
(title: "get rid of uniqueScriptId()")

[commit-bot: I haz the power, 2017-05-02 22:07:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 23:59:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493762799316140,
"parent_rev": "8157c6553d38a82e2fd2d35053626d034420242b", "commit_rev":
"421b9c4b9736e52c903123994d977b4ed406cf72"}

[commit-bot: I haz the power, 2017-05-03 00:00:32]

Description was changed from

==========
DevTools: support resolving a UILocation to multiple raw script locations

This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it
return an array

BUG=717694
==========

to

==========
DevTools: support resolving a UILocation to multiple raw script locations

This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it
return an array

BUG=717694

Review-Url: https://codereview.chromium.org/2857453002
Cr-Commit-Position: refs/heads/master@{#468825}
Committed:
https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d97...
==========

[commit-bot: I haz the power, 2017-05-03 00:00:33]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d97...

[caseq, 2017-05-03 23:56:01]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2859073002/ by caseq@chromium.org.

The reason for reverting is: We decided that we don't need that..