Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2858053003: Delete code in PointIsClippedByAncestorClipNode which checked render surface clip. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
jaydasika, ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete code in PointIsClippedByAncestorClipNode which checked render surface clip. Since all actual semantic clips are represented by the clip tree, this code was only necessary to check for cases when a surface exceeded the maximum texture size. Since the rendering would already be broken in such cases, it seems ok to not count that as a clip, which is correct w.r.t. the semantics of the web page, even if it disagrees with the apparent rendering. Note: the relevant code was added in https://codereview.chromium.org/1551333003. BUG=718149 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2858053003 Cr-Commit-Position: refs/heads/master@{#469183} Committed: https://chromium.googlesource.com/chromium/src/+/51b96b368bc1ebb4b952465a4220f093f6850528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M cc/trees/layer_tree_impl.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
chrishtr
3 years, 7 months ago (2017-05-03 21:37:15 UTC) #5
jaydasika
lgtm % ajuma
3 years, 7 months ago (2017-05-03 21:42:59 UTC) #8
ajuma
lgtm too
3 years, 7 months ago (2017-05-03 21:48:49 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2861593004 Patch 1). Please resolve the dependency and ...
3 years, 7 months ago (2017-05-03 21:49:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858053003/1
3 years, 7 months ago (2017-05-03 23:00:38 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:06:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51b96b368bc1ebb4b952465a4220...

Powered by Google App Engine
This is Rietveld 408576698