Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4631)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2858053003: Delete code in PointIsClippedByAncestorClipNode which checked render surface clip. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index e5c95593eba119c7e507d2bf274bcf7a78409423..d5f2c312e3f03e43ee9a26c1db71e47c0486d456 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -1797,20 +1797,6 @@ static bool PointHitsRegion(const gfx::PointF& screen_space_point,
gfx::ToRoundedPoint(hit_test_point_in_layer_space));
}
-static const gfx::Transform SurfaceScreenSpaceTransform(
- const LayerImpl* layer) {
- const PropertyTrees* property_trees =
- layer->layer_tree_impl()->property_trees();
- RenderSurfaceImpl* render_surface = layer->GetRenderSurface();
- DCHECK(render_surface);
- return layer->contributes_to_drawn_render_surface()
- ? render_surface->screen_space_transform()
- : property_trees
- ->ToScreenSpaceTransformWithoutSurfaceContentsScale(
- render_surface->TransformTreeIndex(),
- render_surface->EffectTreeIndex());
-}
-
static bool PointIsClippedByAncestorClipNode(
const gfx::PointF& screen_space_point,
const LayerImpl* layer) {
@@ -1844,15 +1830,6 @@ static bool PointIsClippedByAncestorClipNode(
return true;
}
}
- const LayerImpl* clip_node_owner =
- layer->layer_tree_impl()->LayerById(clip_node->owning_layer_id);
- RenderSurfaceImpl* render_surface = clip_node_owner->GetRenderSurface();
- if (render_surface &&
- !PointHitsRect(screen_space_point,
- SurfaceScreenSpaceTransform(clip_node_owner),
- render_surface->content_rect(), NULL)) {
- return true;
- }
}
return false;
}
« no previous file with comments | « no previous file | cc/trees/layer_tree_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698