Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1551333003: cc:: Use clip tree instead of layer tree during hit testing (Closed)

Created:
4 years, 11 months ago by jaydasika
Modified:
4 years, 11 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc:: Use clip tree instead of layer tree during hit testing During hit testing, we walk up the layer tree to check if the test point is clipped by some ancestor. This CL makes it use the clip tree instead. (when property trees are enabled) BUG=568758 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4bab6cab4df2a082f47729972d642afa022afc47 Cr-Commit-Position: refs/heads/master@{#367963}

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 4

Patch Set 4 : Rebase #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -21 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 2 3 4 5 6 16 chunks +87 lines, -21 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 2 3 4 5 6 7 1 chunk +128 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
jaydasika
We already have many unit tests that test hit testing and all of them pass ...
4 years, 11 months ago (2016-01-04 23:58:36 UTC) #3
ajuma
https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc#newcode1457 cc/trees/layer_tree_impl.cc:1457: for (int i = 2; i <= layer->clip_tree_index(); ++i) ...
4 years, 11 months ago (2016-01-05 00:44:43 UTC) #4
jaydasika
https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc#newcode1457 cc/trees/layer_tree_impl.cc:1457: for (int i = 2; i <= layer->clip_tree_index(); ++i) ...
4 years, 11 months ago (2016-01-05 18:14:04 UTC) #5
ajuma
https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc#newcode1491 cc/trees/layer_tree_impl.cc:1491: layer->render_surface()->content_rect(), NULL)) { On 2016/01/04 23:58:36, jaydasika wrote: > ...
4 years, 11 months ago (2016-01-05 18:55:11 UTC) #6
jaydasika
https://codereview.chromium.org/1551333003/diff/20001/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/20001/cc/trees/layer_tree_impl.cc#newcode1458 cc/trees/layer_tree_impl.cc:1458: clip_node->id > 1; clip_node = clip_tree.parent(clip_node)) { On 2016/01/05 ...
4 years, 11 months ago (2016-01-05 19:00:02 UTC) #7
jaydasika
https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/1/cc/trees/layer_tree_impl.cc#newcode1491 cc/trees/layer_tree_impl.cc:1491: layer->render_surface()->content_rect(), NULL)) { On 2016/01/05 18:55:11, ajuma wrote: > ...
4 years, 11 months ago (2016-01-06 01:49:15 UTC) #8
ajuma
https://codereview.chromium.org/1551333003/diff/40001/cc/trees/layer_tree_impl_unittest.cc File cc/trees/layer_tree_impl_unittest.cc (right): https://codereview.chromium.org/1551333003/diff/40001/cc/trees/layer_tree_impl_unittest.cc#newcode443 cc/trees/layer_tree_impl_unittest.cc:443: ASSERT_TRUE(result_layer); EXPECT_TRUE (it would make sense to use ASSERT ...
4 years, 11 months ago (2016-01-06 14:18:55 UTC) #9
jaydasika
https://codereview.chromium.org/1551333003/diff/40001/cc/trees/layer_tree_impl_unittest.cc File cc/trees/layer_tree_impl_unittest.cc (right): https://codereview.chromium.org/1551333003/diff/40001/cc/trees/layer_tree_impl_unittest.cc#newcode443 cc/trees/layer_tree_impl_unittest.cc:443: ASSERT_TRUE(result_layer); On 2016/01/06 14:18:55, ajuma wrote: > EXPECT_TRUE > ...
4 years, 11 months ago (2016-01-06 19:31:20 UTC) #10
ajuma
https://codereview.chromium.org/1551333003/diff/100001/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/100001/cc/trees/layer_tree_impl.cc#newcode1443 cc/trees/layer_tree_impl.cc:1443: // clip's bounds. Also, the point can be clipped ...
4 years, 11 months ago (2016-01-06 19:53:45 UTC) #11
jaydasika
https://codereview.chromium.org/1551333003/diff/100001/cc/trees/layer_tree_impl.cc File cc/trees/layer_tree_impl.cc (right): https://codereview.chromium.org/1551333003/diff/100001/cc/trees/layer_tree_impl.cc#newcode1443 cc/trees/layer_tree_impl.cc:1443: // clip's bounds. Also, the point can be clipped ...
4 years, 11 months ago (2016-01-06 22:44:46 UTC) #12
ajuma
On 2016/01/06 22:44:46, jaydasika wrote: > https://codereview.chromium.org/1551333003/diff/100001/cc/trees/layer_tree_impl.cc > File cc/trees/layer_tree_impl.cc (right): > > https://codereview.chromium.org/1551333003/diff/100001/cc/trees/layer_tree_impl.cc#newcode1443 > ...
4 years, 11 months ago (2016-01-06 22:48:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551333003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551333003/140001
4 years, 11 months ago (2016-01-06 23:42:14 UTC) #15
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 11 months ago (2016-01-07 00:04:40 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 00:05:46 UTC) #18
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/4bab6cab4df2a082f47729972d642afa022afc47
Cr-Commit-Position: refs/heads/master@{#367963}

Powered by Google App Engine
This is Rietveld 408576698