Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2857343002: Delete LayerImpl::GetRenderSurface. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete LayerImpl::GetRenderSurface. (and its callsites) The only remaining callsites are in tests. BUG=718149, 557160 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2857343002 Cr-Commit-Position: refs/heads/master@{#469335} Committed: https://chromium.googlesource.com/chromium/src/+/7e3aaf256e6d56290701b3d4b7d982139d8441da

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -566 lines) Patch
M cc/layers/effect_tree_layer_list_iterator_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/layers/layer_position_constraint_unittest.cc View 9 chunks +25 lines, -24 lines 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M cc/test/layer_test_common.h View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 67 chunks +147 lines, -160 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 98 chunks +291 lines, -293 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 6 chunks +23 lines, -25 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_video.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 17 chunks +23 lines, -23 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (16 generated)
chrishtr
3 years, 7 months ago (2017-05-04 03:38:24 UTC) #5
ajuma
lgtm
3 years, 7 months ago (2017-05-04 14:13:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857343002/20001
3 years, 7 months ago (2017-05-04 14:59:14 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 15:04:41 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e3aaf256e6d56290701b3d4b7d9...

Powered by Google App Engine
This is Rietveld 408576698