[DevTools] Pass session id in detach request

[DevTools] Pass session id in detach request

This makes it symmetric to attach/restore and closes the last
gap in public methods not supporting multiclient.

BUG=590878
Review-Url: https://codereview.chromium.org/2858043003
Cr-Commit-Position: refs/heads/master@{#469706}
Committed: https://chromium.googlesource.com/chromium/src/+/e8e3acc298ce63513565847c5e876012d9c67201

[dgozman, 2017-05-04 17:08:19]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[dgozman, 2017-05-04 17:08:38]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2017-05-04 17:08:39]

Take a look please.

[commit-bot: I haz the power, 2017-05-04 17:08:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 17:28:25]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-05-04 21:56:17]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 21:56:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-05-04 22:25:14]

lgtm

[commit-bot: I haz the power, 2017-05-04 23:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 23:44:54]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-05-05 00:18:52]

dgozman@chromium.org changed reviewers:
+ tsepez@chromium.org

[dgozman, 2017-05-05 00:18:52]

Tom, could you please look at devtools_messages? Adding session id parameter to
browser->renderer IPC (similar to others next to it).

[Tom Sepez, 2017-05-05 16:58:56]

Messages LGTM (per conformance with existing message conventions).

[dgozman, 2017-05-05 17:29:54]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-05-05 17:30:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:38:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494005394488800,
"parent_rev": "a8ca2ae5e18523da433d5214a28e01afa697b471", "commit_rev":
"e8e3acc298ce63513565847c5e876012d9c67201"}

[commit-bot: I haz the power, 2017-05-05 17:38:55]

Description was changed from

==========
[DevTools] Pass session id in detach request

This makes it symmetric to attach/restore and closes the last
gap in public methods not supporting multiclient.

BUG=590878
==========

to

==========
[DevTools] Pass session id in detach request

This makes it symmetric to attach/restore and closes the last
gap in public methods not supporting multiclient.

BUG=590878

Review-Url: https://codereview.chromium.org/2858043003
Cr-Commit-Position: refs/heads/master@{#469706}
Committed:
https://chromium.googlesource.com/chromium/src/+/e8e3acc298ce63513565847c5e87...
==========

[commit-bot: I haz the power, 2017-05-05 17:38:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e8e3acc298ce63513565847c5e87...