third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp - Issue 2858043003: [DevTools] Pass session id in detach request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 2858043003: [DevTools] Pass session id in detach request (Closed)

Patch Set: test compile Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

index 46ed512c8ce2add9d6392a19d1beeadca8ada0ed..7cecaa06c56bb0041edb6e5c4e82cb79e0b88453 100644

--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

@@ -412,10 +412,10 @@ void WebSharedWorkerImpl::ReattachDevTools(const WebString& host_id,

ResumeStartup();

}

-void WebSharedWorkerImpl::DetachDevTools() {

+void WebSharedWorkerImpl::DetachDevTools(int session_id) {

WebDevToolsAgent* devtools_agent = main_frame_->DevToolsAgent();

if (devtools_agent)

- devtools_agent->Detach();

+ devtools_agent->Detach(session_id);

}

void WebSharedWorkerImpl::DispatchDevToolsMessage(int session_id,