content/renderer/service_worker/embedded_worker_devtools_agent.cc - Issue 2858043003: [DevTools] Pass session id in detach request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_devtools_agent.cc

Issue 2858043003: [DevTools] Pass session id in detach request (Closed)

Patch Set: test compile Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/embedded_worker_devtools_agent.cc

diff --git a/content/renderer/service_worker/embedded_worker_devtools_agent.cc b/content/renderer/service_worker/embedded_worker_devtools_agent.cc

index 1bca44dc2c1606f663e85f811bfedca808d7a0d6..ed6d267c9a809145f2d85dfa704722ffb1c17657 100644

--- a/content/renderer/service_worker/embedded_worker_devtools_agent.cc

+++ b/content/renderer/service_worker/embedded_worker_devtools_agent.cc

@@ -61,8 +61,8 @@ void EmbeddedWorkerDevToolsAgent::OnReattach(const std::string& host_id,

WebString::FromUTF8(state));

}

-void EmbeddedWorkerDevToolsAgent::OnDetach() {

- webworker_->DetachDevTools();

+void EmbeddedWorkerDevToolsAgent::OnDetach(int session_id) {

+ webworker_->DetachDevTools(session_id);

}

void EmbeddedWorkerDevToolsAgent::OnDispatchOnInspectorBackend(