content/shell/renderer/layout_test/blink_test_runner.cc - Issue 2858043003: [DevTools] Pass session id in detach request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 2858043003: [DevTools] Pass session id in detach request (Closed)

Patch Set: test compile Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/layout_test/blink_test_runner.cc

diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc

index d52fa4d886b729e2a31a920ed82dbd7470821071..2ebaac04168674b27f12d67285fd930adf6e2db7 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.cc

+++ b/content/shell/renderer/layout_test/blink_test_runner.cc

@@ -458,10 +458,7 @@ void BlinkTestRunner::ShowDevTools(const std::string& settings,

void BlinkTestRunner::CloseDevTools() {

Send(new ShellViewHostMsg_CloseDevTools(routing_id()));

- WebDevToolsAgent* agent =

- render_view()->GetMainRenderFrame()->GetWebFrame()->DevToolsAgent();

- if (agent)

- agent->Detach();

+ render_view()->GetMainRenderFrame()->DetachDevToolsForTest();

}

void BlinkTestRunner::EvaluateInWebInspector(int call_id,