Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2858013003: Fix some new tanslate infobar UI bugs (Closed)

Created:
3 years, 7 months ago by Leo
Modified:
3 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some UI bugs. 1, Fix hard code always translate value and show correct "always translate" state in the same session. 2, Refresh langauge list every time, in case use changed source/target language. 3, Fix menu button desc under talkback mode. Tested on my local N5. BUG=703887 Review-Url: https://codereview.chromium.org/2858013003 Cr-Commit-Position: refs/heads/master@{#469573} Committed: https://chromium.googlesource.com/chromium/src/+/2233a90a6442f3d4f927cc47df918898edbf4fb2

Patch Set 1 #

Patch Set 2 : fix menu button accessibility #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/android/java/res/layout/infobar_translate_compact_content.xml View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Leo
This small change will fix some bugs. Tested on my devices. New test suite for ...
3 years, 7 months ago (2017-05-04 06:09:41 UTC) #2
gone
lgtm
3 years, 7 months ago (2017-05-04 17:15:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858013003/20001
3 years, 7 months ago (2017-05-05 01:24:39 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 02:09:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2233a90a6442f3d4f927cc47df91...

Powered by Google App Engine
This is Rietveld 408576698