chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java - Issue 2858013003: Fix some new tanslate infobar UI bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2858013003: Fix some new tanslate infobar UI bugs (Closed)

Patch Set: fix menu button accessibility Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/infobar_translate_compact_content.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

index 4d7592fe35818963c08b398af79e2b83bc077c37..d9aefd6b4cb78da5e524dd3aea1675cbe40ae5b5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

@@ -178,9 +178,14 @@ class TranslateCompactInfoBar extends InfoBar

mLanguageMenuHelper.show(TranslateMenu.MENU_TARGET_LANGUAGE);

return;

case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:

- nativeApplyBoolTranslateOption(

- mNativeTranslateInfoBarPtr, TranslateOption.ALWAYS_TRANSLATE, true);

- showSnackbar(TranslateSnackbarType.ALWAYS_TRANSLATE);

+ mOptions.toggleAlwaysTranslateLanguageState(

+ !mOptions.alwaysTranslateLanguageState());

+ nativeApplyBoolTranslateOption(mNativeTranslateInfoBarPtr,

+ TranslateOption.ALWAYS_TRANSLATE, mOptions.alwaysTranslateLanguageState());

+ // Only show snackbar when "Always Translate" is enabled.

+ if (mOptions.alwaysTranslateLanguageState()) {

+ showSnackbar(TranslateSnackbarType.ALWAYS_TRANSLATE);

+ }

return;

case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:

nativeApplyBoolTranslateOption(