Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/android/java/res/layout/infobar_translate_compact_content.xml

Issue 2858013003: Fix some new tanslate infobar UI bugs (Closed)
Patch Set: fix menu button accessibility Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2017 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- TODO(googleo): Add correct style based on spec and contentDescription. -->
7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" 6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:app="http://schemas.android.com/apk/res-auto" 7 xmlns:app="http://schemas.android.com/apk/res-auto"
9 android:id="@+id/translate_infobar_content" 8 android:id="@+id/translate_infobar_content"
10 android:layout_width="match_parent" 9 android:layout_width="match_parent"
11 android:layout_height="wrap_content" 10 android:layout_height="wrap_content"
12 android:gravity="center_vertical" 11 android:gravity="center_vertical"
13 android:orientation="horizontal"> 12 android:orientation="horizontal">
14 13
15 <org.chromium.chrome.browser.infobar.translate.TranslateTabLayout 14 <org.chromium.chrome.browser.infobar.translate.TranslateTabLayout
16 android:id="@+id/translate_infobar_tabs" 15 android:id="@+id/translate_infobar_tabs"
17 android:layout_width="0dp" 16 android:layout_width="0dp"
18 android:layout_height="wrap_content" 17 android:layout_height="wrap_content"
19 android:layout_weight="1" 18 android:layout_weight="1"
20 android:requiresFadingEdge="horizontal" 19 android:requiresFadingEdge="horizontal"
21 android:fadingEdgeLength="@dimen/infobar_translate_fade_edge_length" 20 android:fadingEdgeLength="@dimen/infobar_translate_fade_edge_length"
22 app:tabIndicatorColor="@color/infobar_accent_blue" 21 app:tabIndicatorColor="@color/infobar_accent_blue"
23 app:tabSelectedTextColor="@color/infobar_accent_blue" 22 app:tabSelectedTextColor="@color/infobar_accent_blue"
24 app:tabGravity="fill" 23 app:tabGravity="fill"
25 app:tabMode="scrollable" /> 24 app:tabMode="scrollable" />
26 25
27 <org.chromium.chrome.browser.widget.TintedImageButton 26 <org.chromium.chrome.browser.widget.TintedImageButton
28 android:id="@+id/translate_infobar_menu_button" 27 android:id="@+id/translate_infobar_menu_button"
29 android:layout_width="wrap_content" 28 android:layout_width="wrap_content"
30 android:layout_height="wrap_content" 29 android:layout_height="wrap_content"
31 android:minHeight="@dimen/min_touch_target_size" 30 android:minHeight="@dimen/min_touch_target_size"
32 android:minWidth="@dimen/min_touch_target_size" 31 android:minWidth="@dimen/min_touch_target_size"
33 android:scaleType="center" 32 android:scaleType="center"
34 android:background="?attr/selectableItemBackground" 33 android:background="?attr/selectableItemBackground"
35 android:contentDescription="@null" 34 android:contentDescription="@string/accessibility_toolbar_btn_menu"
36 android:src="@drawable/btn_menu" 35 android:src="@drawable/btn_menu"
37 app:tint="@color/dark_mode_tint" /> 36 app:tint="@color/dark_mode_tint" />
38 </LinearLayout> 37 </LinearLayout>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698