Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5931)

Unified Diff: chrome/android/java/res/layout/infobar_translate_compact_content.xml

Issue 2858013003: Fix some new tanslate infobar UI bugs (Closed)
Patch Set: fix menu button accessibility Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/infobar_translate_compact_content.xml
diff --git a/chrome/android/java/res/layout/infobar_translate_compact_content.xml b/chrome/android/java/res/layout/infobar_translate_compact_content.xml
index f8e3ab2ce594951468c1ba385d42202218d8e6ea..121e681b31d0af7e17fa40136fcfd027c63b4418 100644
--- a/chrome/android/java/res/layout/infobar_translate_compact_content.xml
+++ b/chrome/android/java/res/layout/infobar_translate_compact_content.xml
@@ -3,7 +3,6 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
-<!-- TODO(googleo): Add correct style based on spec and contentDescription. -->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/translate_infobar_content"
@@ -32,7 +31,7 @@
android:minWidth="@dimen/min_touch_target_size"
android:scaleType="center"
android:background="?attr/selectableItemBackground"
- android:contentDescription="@null"
+ android:contentDescription="@string/accessibility_toolbar_btn_menu"
android:src="@drawable/btn_menu"
app:tint="@color/dark_mode_tint" />
</LinearLayout>
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698