Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

Issue 2857853007: Rename |m_scriptState| to |script_state_| in IDL bindings. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp
index 9d2297295ab5745f0f28c624f83387872c92ea45..c3136e3406cf8bebe5afcbfae109ebd96f255635 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp
@@ -15,38 +15,38 @@ namespace blink {
void V8ResizeObserverCallback::handleEvent(
const HeapVector<Member<ResizeObserverEntry>>& entries,
ResizeObserver* observer) {
- v8::Isolate* isolate = m_scriptState->GetIsolate();
+ v8::Isolate* isolate = script_state_->GetIsolate();
ExecutionContext* execution_context =
- ExecutionContext::From(m_scriptState.Get());
+ ExecutionContext::From(script_state_.Get());
if (!execution_context || execution_context->IsContextSuspended() ||
execution_context->IsContextDestroyed())
return;
- if (!m_scriptState->ContextIsValid())
+ if (!script_state_->ContextIsValid())
return;
- ScriptState::Scope scope(m_scriptState.Get());
+ ScriptState::Scope scope(script_state_.Get());
if (m_callback.IsEmpty())
return;
v8::Local<v8::Value> observer_handle =
- ToV8(observer, m_scriptState->GetContext()->Global(),
- m_scriptState->GetIsolate());
+ ToV8(observer, script_state_->GetContext()->Global(),
+ script_state_->GetIsolate());
if (!observer_handle->IsObject())
return;
v8::Local<v8::Object> this_object =
v8::Local<v8::Object>::Cast(observer_handle);
v8::Local<v8::Value> entries_handle =
- ToV8(entries, m_scriptState->GetContext()->Global(),
- m_scriptState->GetIsolate());
+ ToV8(entries, script_state_->GetContext()->Global(),
+ script_state_->GetIsolate());
if (entries_handle.IsEmpty())
return;
v8::Local<v8::Value> argv[] = {entries_handle, observer_handle};
- v8::TryCatch exception_catcher(m_scriptState->GetIsolate());
+ v8::TryCatch exception_catcher(script_state_->GetIsolate());
exception_catcher.SetVerbose(true);
V8ScriptRunner::CallFunction(
- m_callback.NewLocal(isolate), ExecutionContext::From(m_scriptState.Get()),
+ m_callback.NewLocal(isolate), ExecutionContext::From(script_state_.Get()),
this_object, WTF_ARRAY_LENGTH(argv), argv, isolate);
}

Powered by Google App Engine
This is Rietveld 408576698