Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp

Issue 2857853007: Rename |m_scriptState| to |script_state_| in IDL bindings. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 27 matching lines...) Expand all
38 38
39 v8::Local<v8::Value> ScriptValue::V8Value() const { 39 v8::Local<v8::Value> ScriptValue::V8Value() const {
40 if (IsEmpty()) 40 if (IsEmpty())
41 return v8::Local<v8::Value>(); 41 return v8::Local<v8::Value>();
42 42
43 DCHECK(GetIsolate()->InContext()); 43 DCHECK(GetIsolate()->InContext());
44 44
45 // This is a check to validate that you don't return a ScriptValue to a world 45 // This is a check to validate that you don't return a ScriptValue to a world
46 // different from the world that created the ScriptValue. 46 // different from the world that created the ScriptValue.
47 // Probably this could be: 47 // Probably this could be:
48 // if (&m_scriptState->world() == &DOMWrapperWorld::current(isolate())) 48 // if (&script_state_->world() == &DOMWrapperWorld::current(isolate()))
49 // return v8::Local<v8::Value>(); 49 // return v8::Local<v8::Value>();
50 // instead of triggering RELEASE_ASSERT. 50 // instead of triggering RELEASE_ASSERT.
51 CHECK_EQ(&script_state_->World(), &DOMWrapperWorld::Current(GetIsolate())); 51 CHECK_EQ(&script_state_->World(), &DOMWrapperWorld::Current(GetIsolate()));
52 return value_->NewLocal(GetIsolate()); 52 return value_->NewLocal(GetIsolate());
53 } 53 }
54 54
55 v8::Local<v8::Value> ScriptValue::V8ValueFor( 55 v8::Local<v8::Value> ScriptValue::V8ValueFor(
56 ScriptState* target_script_state) const { 56 ScriptState* target_script_state) const {
57 if (IsEmpty()) 57 if (IsEmpty())
58 return v8::Local<v8::Value>(); 58 return v8::Local<v8::Value>();
(...skipping 18 matching lines...) Expand all
77 return false; 77 return false;
78 result = ToCoreString(v8::Local<v8::String>::Cast(string)); 78 result = ToCoreString(v8::Local<v8::String>::Cast(string));
79 return true; 79 return true;
80 } 80 }
81 81
82 ScriptValue ScriptValue::CreateNull(ScriptState* script_state) { 82 ScriptValue ScriptValue::CreateNull(ScriptState* script_state) {
83 return ScriptValue(script_state, v8::Null(script_state->GetIsolate())); 83 return ScriptValue(script_state, v8::Null(script_state->GetIsolate()));
84 } 84 }
85 85
86 } // namespace blink 86 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698