Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2856583002:
Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk (Closed)
DescriptionReland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk
This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d
(https://codereview.chromium.org/2791933004)
and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695
(https://codereview.chromium.org/2690183002/).
BUG=653916
TBR=jam@chromium.org, rkaplow@chromium.org
Previously reviewed at https://codereview.chromium.org/2690183002/
Review-Url: https://codereview.chromium.org/2856583002
Cr-Original-Commit-Position: refs/heads/master@{#468376}
Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d566487590518ec223
Review-Url: https://codereview.chromium.org/2856583002
Cr-Commit-Position: refs/heads/master@{#469470}
Committed: https://chromium.googlesource.com/chromium/src/+/25e51e9509c43a2475ee820cf83a37df3e9ececb
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 36 (28 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 ==========
robliao@chromium.org changed reviewers: + jam@chromium.org, rkaplow@chromium.org
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ==========
TBR=jam@chromium.org, rkaplow@chromium.org This was previously reviewed at https://codereview.chromium.org/2690183002/
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ==========
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies Patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/) BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ==========
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/) BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by robliao@chromium.org
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916, 707986 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ==========
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493664536019990, "parent_rev":
"f00f17c2badfd4132e5cac30413804ce34f72cbe", "commit_rev":
"3e27cb6e501ae55d614b56d566487590518ec223"}
Message was sent while issue was closed.
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916, 707986 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916, 707986 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ Review-Url: https://codereview.chromium.org/2856583002 Cr-Commit-Position: refs/heads/master@{#468376} Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d56648... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d56648...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2848413002/ by robliao@chromium.org. The reason for reverting is: Possible failure: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLi....
Message was sent while issue was closed.
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916, 707986 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ Review-Url: https://codereview.chromium.org/2856583002 Cr-Commit-Position: refs/heads/master@{#468376} Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d56648... ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ Review-Url: https://codereview.chromium.org/2856583002 Cr-Commit-Position: refs/heads/master@{#468376} Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d56648... ==========
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493931492787780, "parent_rev":
"02b14ba085a0bb98b8d87cd713fb13b9c6d2821a", "commit_rev":
"25e51e9509c43a2475ee820cf83a37df3e9ececb"}
Message was sent while issue was closed.
Description was changed from ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ Review-Url: https://codereview.chromium.org/2856583002 Cr-Commit-Position: refs/heads/master@{#468376} Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d56648... ========== to ========== Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d (https://codereview.chromium.org/2791933004) and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 (https://codereview.chromium.org/2690183002/). BUG=653916 TBR=jam@chromium.org, rkaplow@chromium.org Previously reviewed at https://codereview.chromium.org/2690183002/ Review-Url: https://codereview.chromium.org/2856583002 Cr-Original-Commit-Position: refs/heads/master@{#468376} Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d56648... Review-Url: https://codereview.chromium.org/2856583002 Cr-Commit-Position: refs/heads/master@{#469470} Committed: https://chromium.googlesource.com/chromium/src/+/25e51e9509c43a2475ee820cf83a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/25e51e9509c43a2475ee820cf83a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
