RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (ref. BrowserThreadImpl::StopRedirectionOfThreadID(): 
waiting on the exact same set of tasks it did prior to redirection).

BUG=653916
Review-Url: https://codereview.chromium.org/2690183002
Cr-Commit-Position: refs/heads/master@{#461481}
Committed: https://chromium.googlesource.com/chromium/src/+/b6d0c9a06ab573af760763fcd7ecf76ae2c87695

[gab, 2017-02-13 18:27:54]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 18:28:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 19:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 19:15:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-02-21 20:09:05]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 20:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:58:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gab, 2017-02-21 22:39:59]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 22:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:18:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2017-03-30 19:55:57]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 19:56:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-03-30 20:09:01]

gab@chromium.org changed reviewers:
+ jam@chromium.org, rkaplow@chromium.org

[gab, 2017-03-30 20:09:03]

John PTaL

@Rob for fieldtrial_testing_config.json

Thanks

https://codereview.chromium.org/2690183002/diff/20001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2690183002/diff/20001/content/browser/browser...
content/browser/browser_main_loop.cc:1274:
base::ThreadRestrictions::ScopedAllowWait allow_wait_for_join;
This is the only addition, the rest of the diff is merely side-effects
indentation and re-formatting).

[gab, 2017-03-30 20:09:32]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

BUG=
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

BUG=653916
==========

[commit-bot: I haz the power, 2017-03-30 21:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:16:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rkaplow, 2017-03-31 03:54:52]

lgtm

[jam, 2017-03-31 19:21:29]

sorry for the delay, can you reroute this? I'm busy today and Monday.

[gab, 2017-03-31 19:38:48]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 19:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-31 19:45:09]

lgtm

[gab, 2017-03-31 19:48:20]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

BUG=653916
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already).

BUG=653916
==========

[gab, 2017-03-31 19:49:22]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already).

BUG=653916
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (waiting on the exact same
set of tasks as it did prior to redirection).

BUG=653916
==========

[gab, 2017-03-31 19:49:34]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (waiting on the exact same
set of tasks as it did prior to redirection).

BUG=653916
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (waiting on the exact same
set of tasks it did prior to redirection).

BUG=653916
==========

[gab, 2017-03-31 19:50:22]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (waiting on the exact same
set of tasks it did prior to redirection).

BUG=653916
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (ref.
BrowserThreadImpl::StopRedirectionOfThreadID(): 
waiting on the exact same set of tasks it did prior to redirection).

BUG=653916
==========

[commit-bot: I haz the power, 2017-03-31 21:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 21:14:44]

Dry run: This issue passed the CQ dry run.

[gab, 2017-04-03 02:57:15]

The CQ bit was checked by gab@chromium.org

[gab, 2017-04-03 02:57:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/2690183002/#ps40001
(title: "update dependency")

[commit-bot: I haz the power, 2017-04-03 02:57:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 04:55:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 04:55:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gab, 2017-04-03 14:56:00]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-04-03 14:56:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 17:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:20:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gab, 2017-04-03 17:22:24]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 18:30:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491240144377380,
"parent_rev": "e9db587014de87a149f709a8e1e94a3d5708c835", "commit_rev":
"b6d0c9a06ab573af760763fcd7ecf76ae2c87695"}

[commit-bot: I haz the power, 2017-04-03 18:31:41]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (ref.
BrowserThreadImpl::StopRedirectionOfThreadID(): 
waiting on the exact same set of tasks it did prior to redirection).

BUG=653916
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (ref.
BrowserThreadImpl::StopRedirectionOfThreadID(): 
waiting on the exact same set of tasks it did prior to redirection).

BUG=653916

Review-Url: https://codereview.chromium.org/2690183002
Cr-Commit-Position: refs/heads/master@{#461481}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6d0c9a06ab573af760763fcd7ec...
==========

[commit-bot: I haz the power, 2017-04-03 18:31:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6d0c9a06ab573af760763fcd7ec...

[robliao, 2017-04-04 00:29:52]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2791933004/ by robliao@chromium.org.

The reason for reverting is: Breaks some DBUS code that requests for a message
loop.

[gab, 2017-04-04 19:57:10]

Description was changed from

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (ref.
BrowserThreadImpl::StopRedirectionOfThreadID(): 
waiting on the exact same set of tasks it did prior to redirection).

BUG=653916

Review-Url: https://codereview.chromium.org/2690183002
Cr-Commit-Position: refs/heads/master@{#461481}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6d0c9a06ab573af760763fcd7ec...
==========

to

==========
RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.

The addition of AssertWaitAllowed in
BrowserMainLoop::ShutdownThreadsAndCleanUp()
is required because joining is a "wait" operation. It wasn't required
before because PlatformThread::Join (platform_thread_posix.cc) actually still
does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons
(and I/O is allowed in shutdown already). But this CL enables the redirection
which uses a WaitableEvent to mimic thread join (ref.
BrowserThreadImpl::StopRedirectionOfThreadID(): 
waiting on the exact same set of tasks it did prior to redirection).

BUG=653916

Review-Url: https://codereview.chromium.org/2690183002
Cr-Commit-Position: refs/heads/master@{#461481}
Committed:
https://chromium.googlesource.com/chromium/src/+/b6d0c9a06ab573af760763fcd7ec...
==========