Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2791503002:
Add Redirection For BrowserThread::FILE to the COM STA Task Runner (Closed)
DescriptionAdd Redirection For BrowserThread::FILE to the COM STA Task Runner
Now that the COM STA Task Runner is available, BrowserThread::FILE can
use it on Windows.
BUG=653916
Review-Url: https://codereview.chromium.org/2791503002
Cr-Commit-Position: refs/heads/master@{#470096}
Committed: https://chromium.googlesource.com/chromium/src/+/0e108ddb699df8f9b1cbd409cf2677739b4058a1
Patch Set 1 #Patch Set 2 : Reset CQ Dry Run #Patch Set 3 : Marking Dependent Change #Patch Set 4 : Rebase #Messages
Total messages: 39 (28 generated)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robliao@chromium.org changed reviewers: + gab@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
robliao@chromium.org changed reviewers: + avi@chromium.org
avi@chromium.org: Please review this CL. Thanks!
I can stamp lgtm but I can't talk about correctness.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by gab@chromium.org
On 2017/04/03 18:21:16, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Actually let's hold on https://codereview.chromium.org/2690183002/ landing first so that we get CQ coverage on this CL (otherwise this CL will not be active during CQ but only on waterfall when merged with https://codereview.chromium.org/2690183002/).
On 2017/04/03 18:24:33, gab wrote: > On 2017/04/03 18:21:16, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > Actually let's hold on https://codereview.chromium.org/2690183002/ landing first > so that we get CQ coverage on this CL (otherwise this CL will not be active > during CQ but only on waterfall when merged with > https://codereview.chromium.org/2690183002/). Sure, sgtm.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/03 18:29:23, robliao wrote: > On 2017/04/03 18:24:33, gab wrote: > > On 2017/04/03 18:21:16, commit-bot: I haz the power wrote: > > > CQ is trying da patch. Follow status at > > > > > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > > > Actually let's hold on https://codereview.chromium.org/2690183002/ landing > first > > so that we get CQ coverage on this CL (otherwise this CL will not be active > > during CQ but only on waterfall when merged with > > https://codereview.chromium.org/2690183002/). > > Sure, sgtm. We're going to hold off on landing this to allow us to isolate impacts of changes: 1) Redirecting all the threads. 2) Redirecting the FILE thread.
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Redirection has stuck for a couple of days, so we should be good to go for this change.
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/2791503002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494270643053440,
"parent_rev": "e7a29e9c1db694f2ae80f95baf758d00e25d28e3", "commit_rev":
"0e108ddb699df8f9b1cbd409cf2677739b4058a1"}
Message was sent while issue was closed.
Description was changed from ========== Add Redirection For BrowserThread::FILE to the COM STA Task Runner Now that the COM STA Task Runner is available, BrowserThread::FILE can use it on Windows. BUG=653916 ========== to ========== Add Redirection For BrowserThread::FILE to the COM STA Task Runner Now that the COM STA Task Runner is available, BrowserThread::FILE can use it on Windows. BUG=653916 Review-Url: https://codereview.chromium.org/2791503002 Cr-Commit-Position: refs/heads/master@{#470096} Committed: https://chromium.googlesource.com/chromium/src/+/0e108ddb699df8f9b1cbd409cf26... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/0e108ddb699df8f9b1cbd409cf26... |
