Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2791933004: Revert of RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk. (Closed)

Created:
3 years, 8 months ago by robliao
Modified:
3 years, 8 months ago
Reviewers:
jam, gab, rkaplow
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk. (patchset #3 id:40001 of https://codereview.chromium.org/2690183002/ ) Reason for revert: Breaks some DBUS code that requests for a message loop Original issue's description: > RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk. > > The addition of AssertWaitAllowed in BrowserMainLoop::ShutdownThreadsAndCleanUp() > is required because joining is a "wait" operation. It wasn't required > before because PlatformThread::Join (platform_thread_posix.cc) actually still > does AssertIOAllowed() instead of AssertWaitAllowed() for legacy reasons > (and I/O is allowed in shutdown already). But this CL enables the redirection > which uses a WaitableEvent to mimic thread join (ref. BrowserThreadImpl::StopRedirectionOfThreadID(): > waiting on the exact same set of tasks it did prior to redirection). > > BUG=653916 > > Review-Url: https://codereview.chromium.org/2690183002 > Cr-Commit-Position: refs/heads/master@{#461481} > Committed: https://chromium.googlesource.com/chromium/src/+/b6d0c9a06ab573af760763fcd7ecf76ae2c87695 TBR=jam@chromium.org,rkaplow@chromium.org,gab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653916, 707986 Review-Url: https://codereview.chromium.org/2791933004 Cr-Commit-Position: refs/heads/master@{#461588} Committed: https://chromium.googlesource.com/chromium/src/+/f07732ec0e39ad7e9f1ad279f2624dbdf261803d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -84 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +78 lines, -80 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
robliao
Created Revert of RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk.
3 years, 8 months ago (2017-04-04 00:29:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2791933004/1
3 years, 8 months ago (2017-04-04 00:30:47 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 00:35:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f07732ec0e39ad7e9f1ad279f262...

Powered by Google App Engine
This is Rietveld 408576698