Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 2856343003: [Home] Update progress bar styles (Closed)

Created:
3 years, 7 months ago by mdjones
Modified:
3 years, 7 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Update progress bar styles This change updates the styles used for the progress bar when Chrome Home is enabled. The status bar has been reverted to black by default and will continue to use theme colors. The background color of the progress bar will now match the status bar color and use a 70% white foreground and white for the animation. BUG=718514 Review-Url: https://codereview.chromium.org/2856343003 Cr-Commit-Position: refs/heads/master@{#469725} Committed: https://chromium.googlesource.com/chromium/src/+/e520c4590bfdf0c571bf534ababda17939b9e4ef

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Messages

Total messages: 13 (6 generated)
mdjones
ptal
3 years, 7 months ago (2017-05-04 18:29:34 UTC) #2
Theresa
lgtm % nits https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java (right): https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java#newcode153 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:153: Context context, int height, int topMargin, ...
3 years, 7 months ago (2017-05-04 21:07:58 UTC) #3
mdjones
https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java (right): https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java#newcode153 chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:153: Context context, int height, int topMargin, boolean isChromeHomeEnabled) { ...
3 years, 7 months ago (2017-05-04 23:39:08 UTC) #4
mdjones
+dfalcantara owners
3 years, 7 months ago (2017-05-04 23:39:29 UTC) #6
gone
lgtm
3 years, 7 months ago (2017-05-05 17:09:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856343003/20001
3 years, 7 months ago (2017-05-05 17:29:06 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:16:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e520c4590bfdf0c571bf534ababd...

Powered by Google App Engine
This is Rietveld 408576698