[Home] Update progress bar styles

[Home] Update progress bar styles

This change updates the styles used for the progress bar when Chrome
Home is enabled. The status bar has been reverted to black by default
and will continue to use theme colors. The background color of the
progress bar will now match the status bar color and use a 70% white
foreground and white for the animation.

BUG=718514
Review-Url: https://codereview.chromium.org/2856343003
Cr-Commit-Position: refs/heads/master@{#469725}
Committed: https://chromium.googlesource.com/chromium/src/+/e520c4590bfdf0c571bf534ababda17939b9e4ef

[mdjones, 2017-05-04 18:29:33]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-05-04 18:29:34]

ptal

[Theresa, 2017-05-04 21:07:58]

lgtm % nits

https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
(right):

https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:153:
Context context, int height, int topMargin, boolean isChromeHomeEnabled) {
Instead of using the over-arching feature name here, can we do something like
useStatusBarColorForBackground that's more descriptive of how this class will
respond to the boolean?

https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:412:
setBackgroundColor(ColorUtils.getDarkenedColorForStatusBar(0xFF000000 | color));
Can we avoid hard coding 0xFF000000?

[mdjones, 2017-05-04 23:39:08]

https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
(right):

https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:153:
Context context, int height, int topMargin, boolean isChromeHomeEnabled) {
On 2017/05/04 21:07:58, Theresa wrote:
> Instead of using the over-arching feature name here, can we do something like
> useStatusBarColorForBackground that's more descriptive of how this class will
> respond to the boolean?

Done.

https://codereview.chromium.org/2856343003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java:412:
setBackgroundColor(ColorUtils.getDarkenedColorForStatusBar(0xFF000000 | color));
On 2017/05/04 21:07:58, Theresa wrote:
> Can we avoid hard coding 0xFF000000?

Turns out I don't need it. Done.

[mdjones, 2017-05-04 23:39:29]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2017-05-04 23:39:29]

+dfalcantara owners

[gone, 2017-05-05 17:09:15]

lgtm

[mdjones, 2017-05-05 17:28:41]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-05-05 17:28:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2856343003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-05-05 17:29:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 18:15:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494005321167550,
"parent_rev": "c229a523deb5c69d49f4757d471eb206f6305ca3", "commit_rev":
"e520c4590bfdf0c571bf534ababda17939b9e4ef"}

[commit-bot: I haz the power, 2017-05-05 18:16:25]

Description was changed from

==========
[Home] Update progress bar styles

This change updates the styles used for the progress bar when Chrome
Home is enabled. The status bar has been reverted to black by default
and will continue to use theme colors. The background color of the
progress bar will now match the status bar color and use a 70% white
foreground and white for the animation.

BUG=718514
==========

to

==========
[Home] Update progress bar styles

This change updates the styles used for the progress bar when Chrome
Home is enabled. The status bar has been reverted to black by default
and will continue to use theme colors. The background color of the
progress bar will now match the status bar color and use a 70% white
foreground and white for the animation.

BUG=718514

Review-Url: https://codereview.chromium.org/2856343003
Cr-Commit-Position: refs/heads/master@{#469725}
Committed:
https://chromium.googlesource.com/chromium/src/+/e520c4590bfdf0c571bf534ababd...
==========

[commit-bot: I haz the power, 2017-05-05 18:16:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e520c4590bfdf0c571bf534ababd...