Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java

Issue 2856343003: [Home] Update progress bar styles (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
index f315ee58fac796edbd50baa1ad2788030f93c1eb..4d58b5301b95d05e4f26aa57b2bc1c518dff682f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
@@ -9,7 +9,6 @@ import android.content.res.ColorStateList;
import android.graphics.Canvas;
import android.graphics.Rect;
import android.graphics.drawable.Drawable;
-import android.os.Build;
import android.os.SystemClock;
import android.support.v7.widget.Toolbar;
import android.util.AttributeSet;
@@ -23,6 +22,7 @@ import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.widget.TintedImageButton;
+import org.chromium.chrome.browser.widget.ToolbarProgressBar;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetMetrics;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheetObserver;
@@ -161,17 +161,13 @@ public class BottomToolbarPhone extends ToolbarPhone {
@Override
protected int getProgressBarHeight() {
- // On Android versions that do not support themed status bars (< M), use a thicker progress
- // bar so it is more visible.
- if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
- return getResources().getDimensionPixelSize(R.dimen.chrome_home_progress_bar_height);
- }
- return super.getProgressBarHeight();
+ return getResources().getDimensionPixelSize(R.dimen.chrome_home_progress_bar_height);
}
@Override
- protected boolean getProgressBarUsesThemeColors() {
- return false;
+ protected ToolbarProgressBar createProgressBar() {
+ return new ToolbarProgressBar(
+ getContext(), getProgressBarHeight(), getProgressBarTopMargin(), true);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698