Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3618)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 2856343003: [Home] Update progress bar styles (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
index b27110145b9a110fc6c7bae5d44f46954b094012..cd1597348f20859004656d7a1f2fb2d53f93ff63 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
@@ -94,8 +94,7 @@ public abstract class ToolbarLayout extends FrameLayout implements Toolbar {
ApiCompatibilityUtils.getColorStateList(getResources(), R.color.dark_mode_tint);
mLightModeTint =
ApiCompatibilityUtils.getColorStateList(getResources(), R.color.light_mode_tint);
- mProgressBar = new ToolbarProgressBar(getContext(), getProgressBarHeight(),
- getProgressBarTopMargin(), getProgressBarUsesThemeColors());
+ mProgressBar = createProgressBar();
addOnLayoutChangeListener(new OnLayoutChangeListener() {
@Override
@@ -131,10 +130,11 @@ public abstract class ToolbarLayout extends FrameLayout implements Toolbar {
}
/**
- * @return Whether or not the toolbar's progress bar should use theme colors.
+ * @return A progress bar for Chrome to use.
*/
- protected boolean getProgressBarUsesThemeColors() {
- return true;
+ protected ToolbarProgressBar createProgressBar() {
+ return new ToolbarProgressBar(
+ getContext(), getProgressBarHeight(), getProgressBarTopMargin(), false);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698