[Home] Disable theme colors in toolbar

[Home] Disable theme colors in toolbar

This change disabled theme colors in the toolbar when Chrome Home is
enabled. The primary mechanism for doing this overriding functionality
in the ToolbarDataProvider to always return a default theme color.
Since theme colors are still needed for the status and progress bars,
the tab still needs to retain knowledge of the web contents' theme.
In those cases, the tab is queried instead of the data provider (this
should be cleaned up once a decision is made to keep or remove
themes).

BUG=718932
Review-Url: https://codereview.chromium.org/2862113003
Cr-Commit-Position: refs/heads/master@{#470087}
Committed: https://chromium.googlesource.com/chromium/src/+/f00e42fce417e8d5875914c16417333b10e73e1e

[mdjones, 2017-05-05 17:21:58]

mdjones@chromium.org changed reviewers:
+ twellington@chromium.org

[mdjones, 2017-05-05 17:21:58]

ptal; there are some things I'd like to clean up here, but I'm going to wait
until there's a decision to keep this.

[Theresa, 2017-05-08 17:42:04]

lgtm

I agree that a theme color provider would be useful here, but we should wait to
make sure this change is going to stick before investing the engineering time.

https://codereview.chromium.org/2862113003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
(right):

https://codereview.chromium.org/2862113003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java:1298:
// If the browser controls are at the bottom make sure to use theme colors for
this layout
nit: s/theme colors/default theme color?

[mdjones, 2017-05-08 18:05:32]

https://codereview.chromium.org/2862113003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
(right):

https://codereview.chromium.org/2862113003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java:1298:
// If the browser controls are at the bottom make sure to use theme colors for
this layout
On 2017/05/08 17:42:04, Theresa wrote:
> nit: s/theme colors/default theme color?

Nah, we actually want the theme colors in the stack layout. This basically
overrides the values set by the other two layouts (since layout tabs are
reused).

[mdjones, 2017-05-08 18:05:53]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2017-05-08 18:05:54]

+dfalcantara ptal

[gone, 2017-05-08 18:24:15]

lgtm

[mdjones, 2017-05-08 18:41:17]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-05-08 18:41:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2862113003/#ps40001
(title: "jk")

[commit-bot: I haz the power, 2017-05-08 18:42:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:53:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494268877656820,
"parent_rev": "b1d09797bdb4b4b4340662a5bc25a0d611cc42ba", "commit_rev":
"f00e42fce417e8d5875914c16417333b10e73e1e"}

[commit-bot: I haz the power, 2017-05-08 19:54:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494268877656820,
"parent_rev": "b1d09797bdb4b4b4340662a5bc25a0d611cc42ba", "commit_rev":
"f00e42fce417e8d5875914c16417333b10e73e1e"}

[commit-bot: I haz the power, 2017-05-08 19:54:51]

Description was changed from

==========
[Home] Disable theme colors in toolbar

This change disabled theme colors in the toolbar when Chrome Home is
enabled. The primary mechanism for doing this overriding functionality
in the ToolbarDataProvider to always return a default theme color.
Since theme colors are still needed for the status and progress bars,
the tab still needs to retain knowledge of the web contents' theme.
In those cases, the tab is queried instead of the data provider (this
should be cleaned up once a decision is made to keep or remove
themes).

BUG=718932
==========

to

==========
[Home] Disable theme colors in toolbar

This change disabled theme colors in the toolbar when Chrome Home is
enabled. The primary mechanism for doing this overriding functionality
in the ToolbarDataProvider to always return a default theme color.
Since theme colors are still needed for the status and progress bars,
the tab still needs to retain knowledge of the web contents' theme.
In those cases, the tab is queried instead of the data provider (this
should be cleaned up once a decision is made to keep or remove
themes).

BUG=718932

Review-Url: https://codereview.chromium.org/2862113003
Cr-Commit-Position: refs/heads/master@{#470087}
Committed:
https://chromium.googlesource.com/chromium/src/+/f00e42fce417e8d5875914c16417...
==========

[commit-bot: I haz the power, 2017-05-08 19:54:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f00e42fce417e8d5875914c16417...