Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000

Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000 (patchset #1 id:1 of https://codereview.chromium.org/2862563003/ )

Reason for revert:
Caused net_unittests to consistently time out on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 because of a large number of QUIC tests crashing.

Original issue's description:
> Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
> 
> There are no flags to be updated
> 
> deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.
> 
> It achieved results that were in general comparable to "measuring
> aggregation" approach, but it had worse rtx rate, and worse QoE, and did
> not actually seem to be better in other regards.
> 
> Merge internal change: 154601526
> 
> https://codereview.chromium.org/2859913003/
> 
> fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.
> 
> This causes a dramatic reduction in losses compared to the previous patch.
> 
> The transfer time is approximately the same.
> 
> Merge internal change: 154590929
> 
> https://codereview.chromium.org/2857243002/
> 
> Fix typo in comments.
> 
> Merge internal change: 154539040
> 
> https://codereview.chromium.org/2854823004/
> 
> QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.
> 
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that (2nd in the series).
> 
> [ HTTP stream pairs builds upon this, by having new QuicSpdySession
> overrides that implicitly create headers streams, and abstracting
> stream accounting as needed. ]
> 
> Add a new factory like method QuicSession::CreateStream(), that
> unconditionally creates a new stream.  It's virtual so subclasses of
> QuicSession can create streams that are appropriately specialized from
> QuicStream.  There are new versions of Create*DynamicStream() called
> MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
> ShouldCreate*DynamicStream2().
> 
> Separating this out means that fewer overrides of Create*DynamicStream()
> and ShouldCreate*DynamicStream() will necessary, because many of those
> were actually only needed to specialize the steam types.  Those will go
> away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
> deprecated.
> 
> Merge internal changes: 154351257, 154373998.
> 
> https://codereview.chromium.org/2861673004/
> 
> QUIC - stream id refactor for tests.
> 
> // AKA - http stream pairs bikeshed #1.
> 
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that.
> 
> Rework QUIC tests so that they do not hard code the assumption that
> all headers are on stream 3.  Also, prepare to calculate stream ids
> according to whether stream pairs are enabled, i.e. whether they
> increment by 2 or 4.
> 
> Merge internal change: 150949425
> 
> https://codereview.chromium.org/2854833005/
> 
> 
> R=rch@chromium.org
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2862563003
> Cr-Commit-Position: refs/heads/master@{#469218}
> Committed: https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780ad559877164f

TBR=rch@chromium.org,ckrasic@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2856243003
Cr-Commit-Position: refs/heads/master@{#469324}
Committed: https://chromium.googlesource.com/chromium/src/+/94669e18e9f656ae445355a572bc1ccdf1f78b70

[johnme, 2017-05-04 14:01:50]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-05-04 14:01:50]

Created Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017
+0000

[commit-bot: I haz the power, 2017-05-04 14:02:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 14:03:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493906510001460, "parent_rev":
"f780c40af7e1f7e0f23e582b60811c7e6f1ba436", "commit_rev":
"94669e18e9f656ae445355a572bc1ccdf1f78b70"}

[commit-bot: I haz the power, 2017-05-04 14:03:47]

Description was changed from

==========
Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
(patchset #1 id:1 of https://codereview.chromium.org/2862563003/ )

Reason for revert:
Caused net_unittests to consistently time out on
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
because of a large number of QUIC tests crashing.

Original issue's description:
> Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
> 
> There are no flags to be updated
> 
> deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in
disabled state.
> 
> It achieved results that were in general comparable to "measuring
> aggregation" approach, but it had worse rtx rate, and worse QoE, and did
> not actually seem to be better in other regards.
> 
> Merge internal change: 154601526
> 
> https://codereview.chromium.org/2859913003/
> 
> fix packet conservation to remove packets from recovery window when they are
lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.
> 
> This causes a dramatic reduction in losses compared to the previous patch.
> 
> The transfer time is approximately the same.
> 
> Merge internal change: 154590929
> 
> https://codereview.chromium.org/2857243002/
> 
> Fix typo in comments.
> 
> Merge internal change: 154539040
> 
> https://codereview.chromium.org/2854823004/
> 
> QUIC - refactor stream creation. Guarded by
--quic_reloadable_flag_quic_refactor_stream_creation.
> 
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that (2nd in the series).
> 
> [ HTTP stream pairs builds upon this, by having new QuicSpdySession
> overrides that implicitly create headers streams, and abstracting
> stream accounting as needed. ]
> 
> Add a new factory like method QuicSession::CreateStream(), that
> unconditionally creates a new stream.  It's virtual so subclasses of
> QuicSession can create streams that are appropriately specialized from
> QuicStream.  There are new versions of Create*DynamicStream() called
> MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
> ShouldCreate*DynamicStream2().
> 
> Separating this out means that fewer overrides of Create*DynamicStream()
> and ShouldCreate*DynamicStream() will necessary, because many of those
> were actually only needed to specialize the steam types.  Those will go
> away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
> deprecated.
> 
> Merge internal changes: 154351257, 154373998.
> 
> https://codereview.chromium.org/2861673004/
> 
> QUIC - stream id refactor for tests.
> 
> // AKA - http stream pairs bikeshed #1.
> 
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that.
> 
> Rework QUIC tests so that they do not hard code the assumption that
> all headers are on stream 3.  Also, prepare to calculate stream ids
> according to whether stream pairs are enabled, i.e. whether they
> increment by 2 or 4.
> 
> Merge internal change: 150949425
> 
> https://codereview.chromium.org/2854833005/
> 
> 
> R=rch@chromium.org
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2862563003
> Cr-Commit-Position: refs/heads/master@{#469218}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780...

TBR=rch@chromium.org,ckrasic@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
==========

to

==========
Revert of Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
(patchset #1 id:1 of https://codereview.chromium.org/2862563003/ )

Reason for revert:
Caused net_unittests to consistently time out on
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
because of a large number of QUIC tests crashing.

Original issue's description:
> Landing Recent QUIC changes until Sat Apr 29 00:22:04 2017 +0000
> 
> There are no flags to be updated
> 
> deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in
disabled state.
> 
> It achieved results that were in general comparable to "measuring
> aggregation" approach, but it had worse rtx rate, and worse QoE, and did
> not actually seem to be better in other regards.
> 
> Merge internal change: 154601526
> 
> https://codereview.chromium.org/2859913003/
> 
> fix packet conservation to remove packets from recovery window when they are
lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.
> 
> This causes a dramatic reduction in losses compared to the previous patch.
> 
> The transfer time is approximately the same.
> 
> Merge internal change: 154590929
> 
> https://codereview.chromium.org/2857243002/
> 
> Fix typo in comments.
> 
> Merge internal change: 154539040
> 
> https://codereview.chromium.org/2854823004/
> 
> QUIC - refactor stream creation. Guarded by
--quic_reloadable_flag_quic_refactor_stream_creation.
> 
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that (2nd in the series).
> 
> [ HTTP stream pairs builds upon this, by having new QuicSpdySession
> overrides that implicitly create headers streams, and abstracting
> stream accounting as needed. ]
> 
> Add a new factory like method QuicSession::CreateStream(), that
> unconditionally creates a new stream.  It's virtual so subclasses of
> QuicSession can create streams that are appropriately specialized from
> QuicStream.  There are new versions of Create*DynamicStream() called
> MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
> ShouldCreate*DynamicStream2().
> 
> Separating this out means that fewer overrides of Create*DynamicStream()
> and ShouldCreate*DynamicStream() will necessary, because many of those
> were actually only needed to specialize the steam types.  Those will go
> away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
> deprecated.
> 
> Merge internal changes: 154351257, 154373998.
> 
> https://codereview.chromium.org/2861673004/
> 
> QUIC - stream id refactor for tests.
> 
> // AKA - http stream pairs bikeshed #1.
> 
> This CL is in preparation for HTTP stream pairs changes.  A prototype
> of the entire HTTP stream pairs work is in progress.  This CL is one
> subset of that.
> 
> Rework QUIC tests so that they do not hard code the assumption that
> all headers are on stream 3.  Also, prepare to calculate stream ids
> according to whether stream pairs are enabled, i.e. whether they
> increment by 2 or 4.
> 
> Merge internal change: 150949425
> 
> https://codereview.chromium.org/2854833005/
> 
> 
> R=rch@chromium.org
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2862563003
> Cr-Commit-Position: refs/heads/master@{#469218}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d60018e0b72b5708797cebe57780...

TBR=rch@chromium.org,ckrasic@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2856243003
Cr-Commit-Position: refs/heads/master@{#469324}
Committed:
https://chromium.googlesource.com/chromium/src/+/94669e18e9f656ae445355a572bc...
==========

[commit-bot: I haz the power, 2017-05-04 14:03:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/94669e18e9f656ae445355a572bc...