Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2861673004: QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation. (Closed)

Created:
3 years, 7 months ago by Buck
Modified:
3 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation. This CL is in preparation for HTTP stream pairs changes. A prototype of the entire HTTP stream pairs work is in progress. This CL is one subset of that (2nd in the series). [ HTTP stream pairs builds upon this, by having new QuicSpdySession overrides that implicitly create headers streams, and abstracting stream accounting as needed. ] Add a new factory like method QuicSession::CreateStream(), that unconditionally creates a new stream. It's virtual so subclasses of QuicSession can create streams that are appropriately specialized from QuicStream. There are new versions of Create*DynamicStream() called MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called ShouldCreate*DynamicStream2(). Separating this out means that fewer overrides of Create*DynamicStream() and ShouldCreate*DynamicStream() will necessary, because many of those were actually only needed to specialize the steam types. Those will go away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is deprecated. Merge internal changes: 154351257, 154373998. R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Updated patchset dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -33 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 5 chunks +41 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.cc View 3 chunks +79 lines, -1 line 0 comments Download
M net/quic/core/quic_session_test.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 2 chunks +11 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M net/quic/core/spdy_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quartc/quartc_session.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quartc/quartc_session.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 7 chunks +27 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_base.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 4 chunks +6 lines, -8 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 6 chunks +27 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 4 chunks +39 lines, -11 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (12 generated)
Buck
3 years, 7 months ago (2017-05-03 19:02:59 UTC) #1
Ryan Hamilton
3 years, 7 months ago (2017-05-03 19:17:03 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698