Issue 2859913003: deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2859913003: deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state. (Closed)

Created:
3 years, 7 months ago by Buck

Modified:
3 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state. It achieved results that were in general comparable to "measuring aggregation" approach, but it had worse rtx rate, and worse QoE, and did not actually seem to be better in other regards. Merge internal change: 154601526 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : remove deprecated flag #

Patch Set 3 : Updated patchset dependency #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -92 lines)			Patch
M	net/quic/core/congestion_control/bbr_sender.cc	View		2 chunks	+0 lines, -19 lines	0 comments	Download
M	net/quic/core/congestion_control/bbr_sender_test.cc	View		3 chunks	+0 lines, -67 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 2857243002 Patch 60001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages