Issue 2857243002: fix packet conservation to remove packets from recovery window when they are lost. Protected by FL…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857243002: fix packet conservation to remove packets from recovery window when they are lost. Protected by FL… (Closed)

Created:
3 years, 7 months ago by Buck

Modified:
3 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

fix packet conservation to remove packets from recovery window when they are lost. Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2. This causes a dramatic reduction in losses compared to the previous patch. The transfer time is approximately the same. Merge internal change: 154590929 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Updated patchset dependency #

Patch Set 3 : rebase #

Patch Set 4 : Updated patchset dependency #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -14 lines)			Patch
M	net/quic/core/congestion_control/bbr_sender.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/core/congestion_control/bbr_sender.cc	View	3 chunks	+50 lines, -5 lines	0 comments	Download
M	net/quic/core/congestion_control/bbr_sender_test.cc	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2854823004 Patch 60001

Dependent Patchsets:

Issue 2859913003 Patch 40001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages