DevTools: support uiLocationToRawLocations for CSS

DevTools: support uiLocationToRawLocations for CSS

BUG=717694
Review-Url: https://codereview.chromium.org/2856233002
Cr-Commit-Position: refs/heads/master@{#469426}
Committed: https://chromium.googlesource.com/chromium/src/+/2277d587c39624d35fb97ea65cc610dc29a9306e

[caseq, 2017-05-03 18:55:43]

Description was changed from

==========
DevTools: support uiLocationToRawLocations for CSS

BUG=
==========

to

==========
DevTools: support uiLocationToRawLocations for CSS

BUG=717694
==========

[caseq, 2017-05-03 18:55:57]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[dgozman, 2017-05-04 00:04:56]

https://codereview.chromium.org/2856233002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(right):

https://codereview.chromium.org/2856233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:104:
var rawLocationArrays =
var rawLocations = [];
for (var modelInfo of this._modelInfos.values())
  rawLocations.pushAll(modelInfo._uiLocationToRawLocations(uiLocation);
return rawLocations;

https://codereview.chromium.org/2856233002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
(right):

https://codereview.chromium.org/2856233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js:171:
sourceMap.findReverseEntry(uiLocation.uiSourceCode.url(), uiLocation.lineNumber,
uiLocation.columnNumber);
Could there be multiple?

https://codereview.chromium.org/2856233002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js (right):

https://codereview.chromium.org/2856233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js:365:
findReverseEntry(sourceURL, lineNumber, columnNumber) {
Why this is not similar to JS? Which one is the correct one?

[caseq, 2017-05-04 01:16:32]

All done, ptal.

[caseq, 2017-05-04 01:23:40]

Patchset #2 (id:20001) has been deleted

[dgozman, 2017-05-04 17:44:37]

lgtm

https://codereview.chromium.org/2856233002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(left):

https://codereview.chromium.org/2856233002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:86:
if (!rawLocation)
Seems unrelated :-)

[caseq, 2017-05-04 17:46:49]

https://codereview.chromium.org/2856233002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
(left):

https://codereview.chromium.org/2856233002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js:86:
if (!rawLocation)
On 2017/05/04 17:44:37, dgozman wrote:
> Seems unrelated :-)

It's a drive-by. Compiler, code search and tests think it's fine.

[caseq, 2017-05-04 17:46:54]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2017-05-04 17:47:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 19:39:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493920014261230,
"parent_rev": "b14926c905396fbeb0a77bfc6cce569c8a35fa5f", "commit_rev":
"2277d587c39624d35fb97ea65cc610dc29a9306e"}

[commit-bot: I haz the power, 2017-05-04 19:39:15]

Description was changed from

==========
DevTools: support uiLocationToRawLocations for CSS

BUG=717694
==========

to

==========
DevTools: support uiLocationToRawLocations for CSS

BUG=717694

Review-Url: https://codereview.chromium.org/2856233002
Cr-Commit-Position: refs/heads/master@{#469426}
Committed:
https://chromium.googlesource.com/chromium/src/+/2277d587c39624d35fb97ea65cc6...
==========

[commit-bot: I haz the power, 2017-05-04 19:39:16]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2277d587c39624d35fb97ea65cc6...