third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html - Issue 2856233002: DevTools: support uiLocationToRawLocations for CSS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html

Issue 2856233002: DevTools: support uiLocationToRawLocations for CSS (Closed)

Patch Set: review comments addressed Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/formatter-css-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/formatter-js-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../http/tests/inspector/debugger-test.js"></script>	4 <script src="../../http/tests/inspector/debugger-test.js"></script>

5 <script src="debugger/resources/obfuscated.js"></script>	5 <script src="debugger/resources/obfuscated.js"></script>

6	6

7 <script>	7 <script>

8 async function test()	8 async function test()

9 {	9 {

10 var uiSourceCode = await InspectorTest.waitForUISourceCode("obfuscated.js");	10 var uiSourceCode = await InspectorTest.waitForUISourceCode("obfuscated.js");

(...skipping 16 matching lines...) Expand all Loading...
27	27

28 InspectorTest.addResult("Location mapping without formatted source:");	28 InspectorTest.addResult("Location mapping without formatted source:");

29 dumpLocations(positions);	29 dumpLocations(positions);

30	30

31 InspectorTest.completeTest();	31 InspectorTest.completeTest();

32	32

33 function dumpLocations(positions) {	33 function dumpLocations(positions) {

34 for (var position of positions) {	34 for (var position of positions) {

35 var rawLocation = InspectorTest.debuggerModel.createRawLocation(script, position.lineNumber, position.columnNumber);	35 var rawLocation = InspectorTest.debuggerModel.createRawLocation(script, position.lineNumber, position.columnNumber);

36 var uiLocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocati on(rawLocation);	36 var uiLocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocati on(rawLocation);

37 InspectorTest.addResult(`${rawLocation.lineNumber}:${rawLocation.columnN umber} -> ${uiLocation.lineNumber}:${uiLocation.columnNumber}`);	37 var reverseRawLocation = Bindings.debuggerWorkspaceBinding.uiLocationToR awLocation(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumb er);

	38 InspectorTest.addResult(`${rawLocation.lineNumber}:${rawLocation.columnN umber} -> ${uiLocation.lineNumber}:${uiLocation.columnNumber}` +

	39 ` -> ${reverseRawLocation.lineNumber}:${reverseRawLocation.columnNum ber}`);

38 }	40 }

39 }	41 }

40 }	42 }

41 </script>	43 </script>

42	44

43 </head>	45 </head>

44 <body onload="runTest()">	46 <body onload="runTest()">

45 <p>Tests how SourceFormatter handles JS sources</p>	47 <p>Tests how SourceFormatter handles JS sources</p>

46 </body>	48 </body>

47 </html>	49 </html>

OLD	NEW