third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html - Issue 2856233002: DevTools: support uiLocationToRawLocations for CSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html

Issue 2856233002: DevTools: support uiLocationToRawLocations for CSS (Closed)

Patch Set: review comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/formatter-css-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/formatter-js-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html b/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html

index 8f22c08225069d98dddf120622268060dbebf79c..1e5f83ec08825ca87238c7da133cda24361c2187 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/formatter-js.html

@@ -34,7 +34,9 @@ async function test()

for (var position of positions) {

var rawLocation = InspectorTest.debuggerModel.createRawLocation(script, position.lineNumber, position.columnNumber);

var uiLocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(rawLocation);

- InspectorTest.addResult(`${rawLocation.lineNumber}:${rawLocation.columnNumber} -> ${uiLocation.lineNumber}:${uiLocation.columnNumber}`);

+ var reverseRawLocation = Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber);

+ InspectorTest.addResult(`${rawLocation.lineNumber}:${rawLocation.columnNumber} -> ${uiLocation.lineNumber}:${uiLocation.columnNumber}` +

+ ` -> ${reverseRawLocation.lineNumber}:${reverseRawLocation.columnNumber}`);

}