third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html - Issue 2856233002: DevTools: support uiLocationToRawLocations for CSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html

Issue 2856233002: DevTools: support uiLocationToRawLocations for CSS (Closed)

Patch Set: review comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/formatter-css-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html b/third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html

index bf81aa1039a0628145d4d62d028d0ec37f5c20c6..97a2c7a68164a7abf248f39eddac65d5f1905afc 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/formatter-css.html

@@ -41,7 +41,9 @@ async function test()

InspectorTest.addResult("Mapped locations:");

for (var rawLocation of rawLocations) {

var uiLocation = Bindings.cssWorkspaceBinding.rawLocationToUILocation(rawLocation);

- InspectorTest.addResult(`${rawLocation.lineNumber}:${rawLocation.columnNumber} -> ${uiLocation.lineNumber}:${uiLocation.columnNumber}`);

+ var reverseRawLocation = Bindings.cssWorkspaceBinding.uiLocationToRawLocations(uiLocation)[0];

+ InspectorTest.addResult(`${rawLocation.lineNumber}:${rawLocation.columnNumber} -> ${uiLocation.lineNumber}:${uiLocation.columnNumber} ` +

+ `-> ${reverseRawLocation.lineNumber}:${reverseRawLocation.columnNumber}`);

}

InspectorTest.addResult(`Live locations (updated: ${locationUpdateCount}):`);

for (var liveLocation of liveLocations) {