Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2856173004: Clean up bindings/core/v8 (Part 5) (Closed)

Created:
3 years, 7 months ago by adithyas
Modified:
3 years, 7 months ago
Reviewers:
haraken, jbroman
CC:
darktears, apavlov+blink_chromium.org, awdf+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, chasej+watch_chromium.org, chromium-reviews, cmumford, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, eric.carlson_apple.com, falken+watch_chromium.org, feature-media-reviews_chromium.org, fuzzing_chromium.org, harkness+watch_chromium.org, horo+watch_chromium.org, iclelland+watch_chromuim.org, jbroman+watch_chromium.org, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, kinuko+worker_chromium.org, kinuko+fileapi, kinuko+watch, kinuko+serviceworker, kozyatinskiy+blink_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, michaeln, mlamouri+watch-blink_chromium.org, nhiroki, Peter Beverloo, pfeldman+blink_chromium.org, rwlbuis, serviceworker-reviews, shimazu+serviceworker_chromium.org, shimazu+worker_chromium.org, sof, Srirama, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up bindings/core/v8 (Part 5) This CL removes the following files from bindings/core/v8 and updates all include sites to use their platform/bindings version: - V8PerContextData.h - V8PerIsolateData.h - V8PrivateProperty.h - V8ThrowException.h - V8ValueCache.h - WrapperCreationSecurityCheck.h - WrapperTypeInfo.h BUG=682322 Review-Url: https://codereview.chromium.org/2856173004 Cr-Commit-Position: refs/heads/master@{#469734} Committed: https://chromium.googlesource.com/chromium/src/+/c58cdb27a355fff2a49368760d3b7100d8e73df6

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -324 lines) Patch
M third_party/WebKit/Source/bindings/bindings.gni View 1 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/UseCounterCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCForContextDispose.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ThrowDOMException.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/V8ValueCache.h View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 2 chunks +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/WrapperCreationSecurityCheck.h View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8ExtendableMessageEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamOperationsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDOMFileSystem.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
adithyas
3 years, 7 months ago (2017-05-04 18:37:26 UTC) #6
haraken
LGTM
3 years, 7 months ago (2017-05-05 00:08:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856173004/20001
3 years, 7 months ago (2017-05-05 14:48:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/446196)
3 years, 7 months ago (2017-05-05 15:27:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856173004/40001
3 years, 7 months ago (2017-05-05 15:49:13 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:43:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c58cdb27a355fff2a49368760d3b...

Powered by Google App Engine
This is Rietveld 408576698