Removed |which| from KeyboardEvent and MouseEvent.

Removed |which| from KeyboardEvent and MouseEvent.

Also changed the type of UIEvent.which to unsigned as per the
spec.

Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ



BUG=692717, 496400
Review-Url: https://codereview.chromium.org/2855613002
Cr-Commit-Position: refs/heads/master@{#474261}
Committed: https://chromium.googlesource.com/chromium/src/+/cf13270c47f29b21ce7a8c937f598989cd66c840

[mustaq, 2017-05-01 15:06:57]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 15:07:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 17:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:03:09]

Dry run: This issue passed the CQ dry run.

[use mustaq_at_chromium.org, 2017-05-09 19:54:47]

Description was changed from

==========
Removed |which| from KeyboardEvent and MouseEvent.

BUG=692717
==========

to

==========
Removed |which| from KeyboardEvent and MouseEvent.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ

BUG=692717
==========

[use mustaq_at_chromium.org, 2017-05-09 21:12:47]

mustaq@google.com changed reviewers:
+ dtapuska@chromium.org, mustaq@google.com

[use mustaq_at_chromium.org, 2017-05-09 21:12:47]

ptal

[dtapuska, 2017-05-09 21:20:53]

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/UIEvent.idl (right):

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/UIEvent.idl:38: [MeasureAs=UIEventWhich]
readonly attribute unsigned long which;
Do we anticipate any issues with changing this from a long to an unsigned long?

[dtapuska, 2017-05-09 21:22:37]

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/UIEventInit.idl (right):

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/UIEventInit.idl:10: unsigned long which =
0;
Shouldn't the constructor of the UIEvent now store this field? And we should use
it instead of having virtuals for which?

[use mustaq_at_chromium.org, 2017-05-10 17:48:35]

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/UIEvent.idl (right):

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/UIEvent.idl:38: [MeasureAs=UIEventWhich]
readonly attribute unsigned long which;
On 2017/05/09 21:20:53, dtapuska wrote:
> Do we anticipate any issues with changing this from a long to an unsigned
long?

Not really:
- For MouseEvent, which() currently returns non-zero positive integers.
- For KeyboardEvent, the returned values can be traced back to 16bit unsigned
values (Source/platform/KeyboardCodes.h or WebKeyboard.text[0]). Moreover, FF
already has "unsigned" as per the spec.

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/UIEventInit.idl (right):

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/UIEventInit.idl:10: unsigned long which =
0;
On 2017/05/09 21:22:37, dtapuska wrote:
> Shouldn't the constructor of the UIEvent now store this field? And we should
use
> it instead of having virtuals for which?

The problem is that KeyboardEvent.which() ultimately depends on 3 fields
(windows_key_code, native_key_code and text[0]) of WebKeyboardEvent. Until the
stored WebKeyboardEvent is made read-only, I don't see an efficient way to store
the value in UIEvent.

[use mustaq_at_chromium.org, 2017-05-10 17:50:13]

Description was changed from

==========
Removed |which| from KeyboardEvent and MouseEvent.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ

BUG=692717
==========

to

==========
Removed |which| from KeyboardEvent and MouseEvent.

Also changed the type of UIEvent.which to unsigned as per the
spec.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ



BUG=692717, 496400
==========

[use mustaq_at_chromium.org, 2017-05-11 20:47:46]

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/UIEventInit.idl (right):

https://codereview.chromium.org/2855613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/UIEventInit.idl:10: unsigned long which =
0;
On 2017/05/10 17:48:35, use mustaq_at_chromium.org wrote:
> On 2017/05/09 21:22:37, dtapuska wrote:
> > Shouldn't the constructor of the UIEvent now store this field? And we should
> use
> > it instead of having virtuals for which?
> 
> The problem is that KeyboardEvent.which() ultimately depends on 3 fields
> (windows_key_code, native_key_code and text[0]) of WebKeyboardEvent. Until the
> stored WebKeyboardEvent is made read-only, I don't see an efficient way to
store
> the value in UIEvent.

As discussed offline, I will bring back the UIEventInit.which in a follow-up CL
.

[mustaq, 2017-05-18 17:52:47]

The CQ bit was checked by mustaq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 17:53:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 23:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 23:40:41]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2017-05-23 17:58:14]

https://codereview.chromium.org/2855613002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/UIEvent.idl (right):

https://codereview.chromium.org/2855613002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/UIEvent.idl:38: [MeasureAs=UIEventWhich]
readonly attribute unsigned long which;
Remove the measureAs

[mustaq, 2017-05-23 18:21:31]

https://codereview.chromium.org/2855613002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/UIEvent.idl (right):

https://codereview.chromium.org/2855613002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/UIEvent.idl:38: [MeasureAs=UIEventWhich]
readonly attribute unsigned long which;
On 2017/05/23 17:58:14, dtapuska wrote:
> Remove the measureAs

Done.

[dtapuska, 2017-05-23 18:24:54]

On 2017/05/23 18:21:31, mustaq wrote:
>
https://codereview.chromium.org/2855613002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/UIEvent.idl (right):
> 
>
https://codereview.chromium.org/2855613002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/UIEvent.idl:38: [MeasureAs=UIEventWhich]
> readonly attribute unsigned long which;
> On 2017/05/23 17:58:14, dtapuska wrote:
> > Remove the measureAs
> 
> Done.

lgtm

[mustaq, 2017-05-23 18:25:11]

The CQ bit was checked by mustaq@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:26:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:34:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 18:34:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mustaq, 2017-05-23 19:19:40]

mustaq@chromium.org changed reviewers:
+ foolip@chromium.org
- mustaq@google.com

[mustaq, 2017-05-23 19:19:41]

foolip@: Need approval for global-interface-listing

[foolip, 2017-05-24 11:51:36]

On 2017/05/23 19:19:41, mustaq wrote:
> foolip@: Need approval for global-interface-listing

lgtm

[dtapuska, 2017-05-24 12:27:09]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2017-05-24 12:27:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 12:33:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495628829913100,
"parent_rev": "247725c00faa32d43ce0d8d8833edf4167b36ee1", "commit_rev":
"cf13270c47f29b21ce7a8c937f598989cd66c840"}

[commit-bot: I haz the power, 2017-05-24 12:33:46]

Description was changed from

==========
Removed |which| from KeyboardEvent and MouseEvent.

Also changed the type of UIEvent.which to unsigned as per the
spec.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ



BUG=692717, 496400
==========

to

==========
Removed |which| from KeyboardEvent and MouseEvent.

Also changed the type of UIEvent.which to unsigned as per the
spec.

Blink intent thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6V4iHkqZXvQ



BUG=692717, 496400

Review-Url: https://codereview.chromium.org/2855613002
Cr-Commit-Position: refs/heads/master@{#474261}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf13270c47f29b21ce7a8c937f59...
==========

[commit-bot: I haz the power, 2017-05-24 12:33:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf13270c47f29b21ce7a8c937f59...