Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/core/events/KeyboardEvent.cpp

Issue 2855613002: Removed |which| from KeyboardEvent and MouseEvent. (Closed)
Patch Set: Removed FIXME, counters. Rebased. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/KeyboardEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/KeyboardEvent.cpp b/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
index d1a38933303514c1bedf69981e981fdc15e986ad..e95396cc9e3759a28bc52620e0e0dbe74605d851 100644
--- a/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
+++ b/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
@@ -187,11 +187,11 @@ bool KeyboardEvent::IsKeyboardEvent() const {
return true;
}
-int KeyboardEvent::which() const {
+unsigned KeyboardEvent::which() const {
// Netscape's "which" returns a virtual key code for keydown and keyup, and a
// character code for keypress. That's exactly what IE's "keyCode" returns.
// So they are the same for keyboard events.
- return keyCode();
+ return (unsigned)keyCode();
}
void KeyboardEvent::InitLocationModifiers(unsigned location) {
« no previous file with comments | « third_party/WebKit/Source/core/events/KeyboardEvent.h ('k') | third_party/WebKit/Source/core/events/KeyboardEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698