third_party/WebKit/Source/core/events/UIEventInit.idl - Issue 2855613002: Removed |which| from KeyboardEvent and MouseEvent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/events/UIEventInit.idl

Issue 2855613002: Removed |which| from KeyboardEvent and MouseEvent. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/uievents/#idl-def-UIEventInit	5 // https://w3c.github.io/uievents/#idl-def-UIEventInit

6	6

7 dictionary UIEventInit : EventInit {	7 dictionary UIEventInit : EventInit {

8 Window? view = null;	8 Window? view = null;

9 long detail = 0;	9 long detail = 0;

	10 unsigned long which = 0;
	dtapuska 2017/05/09 21:22:37 Shouldn't the constructor of the UIEvent now store Shouldn't the constructor of the UIEvent now store this field? And we should use it instead of having virtuals for which? use mustaq_at_chromium.org 2017/05/10 17:48:35 The problem is that KeyboardEvent.which() ultimate Show quoted text On 2017/05/09 21:22:37, dtapuska wrote: > Shouldn't the constructor of the UIEvent now store this field? And we should use > it instead of having virtuals for which? The problem is that KeyboardEvent.which() ultimately depends on 3 fields (windows_key_code, native_key_code and text[0]) of WebKeyboardEvent. Until the stored WebKeyboardEvent is made read-only, I don't see an efficient way to store the value in UIEvent. use mustaq_at_chromium.org 2017/05/11 20:47:46 As discussed offline, I will bring back the UIEven Show quoted text On 2017/05/10 17:48:35, use mustaq_at_chromium.org wrote: > On 2017/05/09 21:22:37, dtapuska wrote: > > Shouldn't the constructor of the UIEvent now store this field? And we should > use > > it instead of having virtuals for which? > > The problem is that KeyboardEvent.which() ultimately depends on 3 fields > (windows_key_code, native_key_code and text[0]) of WebKeyboardEvent. Until the > stored WebKeyboardEvent is made read-only, I don't see an efficient way to store > the value in UIEvent. As discussed offline, I will bring back the UIEventInit.which in a follow-up CL .
10 InputDeviceCapabilities? sourceCapabilities = null;	11 InputDeviceCapabilities? sourceCapabilities = null;

11 };	12 };

OLD	NEW

« third_party/WebKit/Source/core/events/UIEvent.idl ('K') | « third_party/WebKit/Source/core/events/UIEvent.idl ('k') | no next file » | no next file with comments »