Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: third_party/WebKit/Source/core/events/MouseEvent.cpp

Issue 2855613002: Removed |which| from KeyboardEvent and MouseEvent. (Closed)
Patch Set: Removed FIXME, counters. Rebased. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/MouseEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/MouseEvent.cpp b/third_party/WebKit/Source/core/events/MouseEvent.cpp
index 62b5aed35452405c407653f38f16c6c999ff5d6b..29d148ae9df33892a8c9763ce246c9d5e9cbc8c7 100644
--- a/third_party/WebKit/Source/core/events/MouseEvent.cpp
+++ b/third_party/WebKit/Source/core/events/MouseEvent.cpp
@@ -396,13 +396,13 @@ short MouseEvent::button() const {
return button_;
}
-int MouseEvent::which() const {
+unsigned MouseEvent::which() const {
// For the DOM, the return values for left, middle and right mouse buttons are
// 0, 1, 2, respectively.
// For the Netscape "which" property, the return values for left, middle and
// right mouse buttons are 1, 2, 3, respectively.
// So we must add 1.
- return button_ + 1;
+ return (unsigned)(button_ + 1);
}
Node* MouseEvent::toElement() const {
« no previous file with comments | « third_party/WebKit/Source/core/events/MouseEvent.h ('k') | third_party/WebKit/Source/core/events/MouseEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698