[Android] Remove --test-arguments arg from test_runner.py.

[Android] Remove --test-arguments arg from test_runner.py.

Deprecated in favor of passing such arguments to test_runner.py
directly.

BUG=700366
Review-Url: https://codereview.chromium.org/2855483003
Cr-Commit-Position: refs/heads/master@{#471096}
Committed: https://chromium.googlesource.com/chromium/src/+/6a94be3b51f4a7d8b49ff2c4fb690dc12b7a6ae3

[jbudorick, 2017-05-01 18:55:26]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org, shenghuazhang@chromium.org

[shenghuazhang, 2017-05-01 19:32:28]

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance_test.py
(right):

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance_test.py:50:
'test_arguments',
I think this arg 'test_arguments' can be removed as well? Same below.

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance_test.py:55:
strict_mode=None, regenerate_goldens=None, test_arguments=None):
Same here.

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance_test.py:58:
regenerate_goldens, test_arguments)
And here?

[jbudorick, 2017-05-01 19:35:54]

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
File build/android/pylib/instrumentation/instrumentation_test_instance_test.py
(right):

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance_test.py:50:
'test_arguments',
On 2017/05/01 19:32:28, shenghuazhang wrote:
> I think this arg 'test_arguments' can be removed as well? Same below.

Done. Nice catch.

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance_test.py:55:
strict_mode=None, regenerate_goldens=None, test_arguments=None):
On 2017/05/01 19:32:28, shenghuazhang wrote:
> Same here.

Done.

https://codereview.chromium.org/2855483003/diff/1/build/android/pylib/instrum...
build/android/pylib/instrumentation/instrumentation_test_instance_test.py:58:
regenerate_goldens, test_arguments)
On 2017/05/01 19:32:28, shenghuazhang wrote:
> And here?

Done.

[shenghuazhang, 2017-05-01 19:36:33]

lgtm

[jbudorick, 2017-05-01 19:43:00]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 19:43:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 20:25:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 20:25:05]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jbudorick, 2017-05-04 20:51:44]

The CQ bit was checked by jbudorick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 20:52:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 22:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:20:59]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mikecase (-- gone --), 2017-05-08 17:07:55]

lgtm

I will say, recently Ive been accidently mixing up some flags, like

--results-json
--test-results-json
--results-json-file

and then being briefly confused why it didn't work and why I didn't get an
error.
idk if there is any good solution to this other than me just learning the flags
better.

regardless, lgtm

[jbudorick, 2017-05-08 17:10:17]

On 2017/05/08 17:07:55, mikecase wrote:
> lgtm
> 
> I will say, recently Ive been accidently mixing up some flags, like
> 
> --results-json
> --test-results-json
> --results-json-file
> 
> and then being briefly confused why it didn't work and why I didn't get an
> error.
> idk if there is any good solution to this other than me just learning the
flags
> better.

The solution generally should be a combination of:
 - renaming flags to make them clearer
 - removing flags that are unnecessary, whether because they're duplicates or
because they're unused

Not sure about the specific case off-hand.

> 
> regardless, lgtm

[jbudorick, 2017-05-08 17:10:52]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2017-05-08 17:10:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
shenghuazhang@chromium.org
Link to the patchset: https://codereview.chromium.org/2855483003/#ps40001
(title: "gtests")

[commit-bot: I haz the power, 2017-05-08 17:11:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 18:47:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:47:59]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbudorick, 2017-05-09 17:06:54]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2017-05-09 17:07:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 21:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 21:42:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbudorick, 2017-05-11 19:56:50]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2017-05-11 19:56:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org, shenghuazhang@chromium.org
Link to the patchset: https://codereview.chromium.org/2855483003/#ps60001
(title: "trivial rebase")

[commit-bot: I haz the power, 2017-05-11 19:57:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 22:38:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494532610976790,
"parent_rev": "2389662b9fb0735446c5c8235bcdc1b0ff505366", "commit_rev":
"6a94be3b51f4a7d8b49ff2c4fb690dc12b7a6ae3"}

[commit-bot: I haz the power, 2017-05-11 22:38:55]

Description was changed from

==========
[Android] Remove --test-arguments arg from test_runner.py.

Deprecated in favor of passing such arguments to test_runner.py
directly.

BUG=700366
==========

to

==========
[Android] Remove --test-arguments arg from test_runner.py.

Deprecated in favor of passing such arguments to test_runner.py
directly.

BUG=700366

Review-Url: https://codereview.chromium.org/2855483003
Cr-Commit-Position: refs/heads/master@{#471096}
Committed:
https://chromium.googlesource.com/chromium/src/+/6a94be3b51f4a7d8b49ff2c4fb69...
==========

[commit-bot: I haz the power, 2017-05-11 22:38:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6a94be3b51f4a7d8b49ff2c4fb69...