Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance_test.py

Issue 2855483003: [Android] Remove --test-arguments arg from test_runner.py. (Closed)
Patch Set: trivial rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/instrumentation_test_instance_test.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance_test.py b/build/android/pylib/instrumentation/instrumentation_test_instance_test.py
index 2ff8a36eb58097bfeedeff2c0efa5d0d382c6e6a..301f95a191ffb5f173e81d2c7044dc7845fd03e0 100755
--- a/build/android/pylib/instrumentation/instrumentation_test_instance_test.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance_test.py
@@ -47,15 +47,14 @@ class InstrumentationTestInstanceTest(unittest.TestCase):
'device_flags_file',
'strict_mode',
'regenerate_goldens',
- 'test_arguments',
])
def createFlagAttributesArgs(
self, command_line_flags=None, device_flags_file=None,
- strict_mode=None, regenerate_goldens=None, test_arguments=None):
+ strict_mode=None, regenerate_goldens=None):
return self._FlagAttributesArgs(
command_line_flags, device_flags_file, strict_mode,
- regenerate_goldens, test_arguments)
+ regenerate_goldens)
def test_initializeFlagAttributes_commandLineFlags(self):
o = self.createTestInstance()
@@ -92,12 +91,6 @@ class InstrumentationTestInstanceTest(unittest.TestCase):
self.assertEquals(
o._flags, ['--enable-test-intents', '--regenerate-goldens'])
- def test_initializeFlagAttributes_testArgumentsRaisesException(self):
- o = self.createTestInstance()
- args = self.createFlagAttributesArgs(test_arguments='--foo --bar')
- with self.assertRaises(Exception):
- o._initializeFlagAttributes(args)
-
def testGetTests_noFilter(self):
o = self.createTestInstance()
raw_tests = [
« no previous file with comments | « build/android/pylib/instrumentation/instrumentation_test_instance.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698